Binary sv2 cleanup#2200
Draft
Shourya742 wants to merge 12 commits into
Draft
Conversation
This was
linked to
issues
Jun 17, 2026
Binary_sv2: From<Vec<T>> for Seq0255 and From<Vec<T>> for Seq064K bypass the length invariants
#2176
Open
Shourya742
force-pushed
the
2026-06-16-binary-sv2-cleanup
branch
3 times, most recently
from
04c7653 to
46da424
Compare
Member
Author
|
Awesome, the test are passing, atleast I have not broken any invariants. Need to improve API ergonomics and should be good to go. |
Shourya742
force-pushed
the
2026-06-16-binary-sv2-cleanup
branch
from
edced03 to
ff49bfd
Compare
…esn't leak internal implementation
Shourya742
force-pushed
the
2026-06-16-binary-sv2-cleanup
branch
from
ff49bfd to
2f82c63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #2171 #2173 #2176 #2177 #2178 #2179
companion stratum-mining/sv2-apps#576