Repository navigation
Conversation
Pecacheu
requested changes
Oct 8, 2026
Contributor
There was a problem hiding this comment.
Getting this error sometimes when adding or removing a favorite emoji (particularly the first/last one) and the UI doesn't update when this error throws (but if you close and reopen the emoji picker, you will see it did still save the new favorites list) Update: Was because I didn't pull your latest change, sorry. The second thing below still applies tho.
The option to favorite GIFs doesn't appear in the right-click menu for sent GIFs, and there is no right-click menu for GIFs in the GIF picker. It's important that the option also be in the context menu because on mobile, floating hover controls won't work properly, so the press-and-hold context menu is the only way to perform a special action.
Dadadah
force-pushed
the
feat/favourites
branch
from
October 11, 2026 16:42
aac451c to
0a89402
Compare
Dadadah
force-pushed
the
feat/favourites
branch
from
October 14, 2026 03:44
07ed63e to
859b773
Compare
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Dadadah
force-pushed
the
feat/favourites
branch
from
October 14, 2026 04:53
859b773 to
86e933e
Compare
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a favourites section to the gif and emoji pickers. Also adds recently used emojis to the emoji picker. Adds a small overlay to gifs that shows up on hover that has a star. Star is filled if favourited and clicking it toggles favourability.
Closes #1256
Closes #758
How was this PR tested?
Favourited some stuff
Screenshots & Screencasts (if appropriate)
Gif Picker:
Favourite gif tab:
Favourite gif star in the picker:
Non-favourite gif star in the picker:
Favourite gif with star in messages:
Favourites and recently used emojis:
Easter 🥚, alt click custom emojis to steal them:
Unfavouriting a gif context menu:
Favouriting a gif context menu:
Same context menu in the gif picker:
main