temp3 matrix implementation - #4635
Draft
vivekavuthu wants to merge 3 commits into
Draft
Conversation
vivekavuthu
force-pushed
the
templates_dicttree_newRoute
branch
from
June 24, 2026 16:04
254830d to
8156d3d
Compare
vivekavuthu
force-pushed
the
templates_dicttree_newRoute
branch
3 times, most recently
from
July 30, 2026 15:23
0a5d5bc to
d4a03df
Compare
vivekavuthu
force-pushed
the
templates_dicttree_newRoute
branch
from
August 3, 2026 20:41
d4a03df to
4cf96cb
Compare
vivekavuthu
force-pushed
the
templates_dicttree_newRoute
branch
from
August 20, 2026 15:21
4b4ba84 to
9aeba37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new data-driven "Templates 3" (Template Mapping) view for PrOFILE, which provides a flexible Module → Domain → chart-template overview. The implementation is fully generic: all layout, labels, colors, chart types, and ordering come from the dataset's config, not hardcoded. The pull request includes the new view, its integration, type definitions, and unit tests for its core logic.
Templates 3 (Template Mapping) View Implementation:
profileForms3chart type and menu entry ingetChartTypeList(client/mass/charts.js) and enabled dynamic import of its implementation (client/plots/importPlot.js).Templates 3data-driven view inclient/plots/profile/form3.ts, including:assertTemplateMapping)buildTemplateView)Type System and Config Updates:
shared/types/src/dataset.tsfor the template mapping contract, includingTemplateChart,TemplateMeta,TemplateFormLegend,TemplateDomain,TemplateModule, andTemplateMappingto ensure datasets and client agree on structure and meaning.Testing:
buildTemplateView,assertTemplateMapping) inclient/plots/profile/test/form3.unit.spec.ts, covering correct grouping, template meta resolution, NEW status propagation, and all structural validation errors.This pull request introduces a new "Templates 3" chart picker for profile forms, providing a data-driven, module/domain matrix/list UI for selecting chart types. It ensures chart-type options are always in sync with the underlying data by deriving available chart types directly from the database, rather than static config. The update also includes unit tests for the new logic.Templates 3 chart picker implementation:
mass/charts.js, which launches a matrix/list menu for selecting profile forms charts.profile/forms3.ts, which:Database-driven chart type derivation:
profile/formsChartTypes.ts, providing functions to:Integration and testing:
plots/importPlot.jsto support dynamic import of the newprofile/forms3.tschart type.test/forms3.unit.spec.tsto validate the grouping, mapping, and cross-domain logic of the new picker.# DescriptionChecklist
Check each task that has been performed or verified to be not applicable.