Add psgix.harakiri support to FCGI::Engine::PSGI - #3
Open
ianburrell wants to merge 3 commits into
Open
Conversation
ianburrell
force-pushed
the
psgi-harakiri
branch
2 times, most recently
from
January 11, 2016 22:01
798944a to
784e893
Compare
added 2 commits
January 11, 2016 14:30
Refactor process_request to support running code after finishing request Pass proc_manager to prepare_environment
ianburrell
force-pushed
the
psgi-harakiri
branch
from
January 11, 2016 22:55
784e893 to
faf864c
Compare
Author
|
I changed the implementation. Instead of having cleanup_request method, I moved everything inside loop into process_request and used "around" (after would also work) in FCGI::Engine::PSGI to change behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FCGI::Engine::PSGI doesn't support the psgix.harakiri extension to allow app to request server to exit (usually to restart).
I added an empty cleanup_request method to handle the cleanup, but it might make sense to move the block inside while loop into method and do "after" or "around" modifier on that.
Also, FCGI::Engine should call FCGI::Request::Finish before post_dispatch. The FCGI::Request gets finished the next time around the loop, but that doesn't cleanup nicely if process exits.