Repository navigation
Conversation
When kadence_blocks_params says the Kadence theme runs in FSE mode and lists the block in siteStylesBlocks, the Block Defaults panel shows a note instead of Save / Modify / Reset, with an Edit site styles button when kadence-blocks' kadence/site-styles store exists (the Site Editor). The store is looked up by name, so this package doesn't depend on kadence-blocks code.
KadenceBlockDefaults returned before its hooks for non-admins and for blocks that use site styles. The Save / Modify / Reset panel is now its own component, so the wrapper's early returns no longer skip hooks.
Say that site styles replace Block Defaults and apply to every block of the type without its own setting. Rename canOpen to canOpenPanel and note that kadence-blocks registers the store only where the panel is mounted.
… note The note uses the block's title, and in the post editor links to the block's screen under Styles > Blocks in the Site Editor.
The control kept the last colour picked in it over its value prop, so after Undo, a reset or a change from another control it still showed the old colour. A value that no longer matches it now replaces it, and the opacity follows its prop the same way.
A value that changed to a palette slug before anything was picked in the control kept the old flag and was drawn as a literal colour.
A value that changed to a palette slug kept the old flag for one render, so the picker drew the raw token (black) until an effect caught up. The flag now comes from the value itself unless a colour is being picked in the control; the effect only clears that local colour.
The resolved color.palette setting returns one origin, so a single user color in Global Styles hid the theme palette. The pop color controls and the gradient color stops now read the theme, default (when enabled) and user origins through usePaletteSwatches(), in core's order. Adds the wp-scripts unit test harness for the pure helper.
…aults SOFT-4745: point Block Defaults to site styles in FSE mode
Offer every palette origin in the color controls
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
# Conflicts: # src/inline-pop-color/index.js # src/single-pop-color-control/index.js
Sync release/fse with 1.1.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR accumulates changes for the FSE project.