[Do not merge] Msvc discover toolchain - #8
Open
shumpohl wants to merge 4 commits into
Open
Conversation
stefanseefeld
force-pushed
the
develop
branch
5 times, most recently
from
November 7, 2018 17:16
f9fab20 to
d0e74b8
Compare
Owner
|
I just had a look into your patch. The reason it fails one of the CI builds is that you changed the ordering of the found toolchains using a simple lexicographical comparison. So it happens that, while versions above "10" are all correctly ordered, versions "9.x" end up with higher priority and so is chosen for the test runs. I may look into ways to rewrite the patch, but feel free to follow up yourself. |
stefanseefeld
force-pushed
the
develop
branch
7 times, most recently
from
July 22, 2020 14:44
572eac6 to
05dfeed
Compare
stefanseefeld
force-pushed
the
develop
branch
5 times, most recently
from
August 1, 2020 21:39
8ef1164 to
aa0b035
Compare
stefanseefeld
force-pushed
the
develop
branch
8 times, most recently
from
December 21, 2020 17:37
62ed686 to
eb6e1a7
Compare
stefanseefeld
force-pushed
the
develop
branch
5 times, most recently
from
December 21, 2020 20:28
148a302 to
5b9ae5e
Compare
stefanseefeld
force-pushed
the
develop
branch
2 times, most recently
from
February 7, 2021 21:16
1fceedf to
0f369a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5 ?
I'm not shure if this works correctly in all cases.