Skip to content

Check c++ version based on msvc version - #7

Open
shumpohl wants to merge 1 commit into
stefanseefeld:developfrom
shumpohl:msvc_cxx_version_check
Open

Check c++ version based on msvc version#7
shumpohl wants to merge 1 commit into
stefanseefeld:developfrom
shumpohl:msvc_cxx_version_check

Conversation

@shumpohl

Copy link
Copy Markdown

See #6

@shumpohl

Copy link
Copy Markdown
Author

Strange. The tests do not fail on my machine and dnot seem connected to the code changes.

@stefanseefeld
stefanseefeld force-pushed the develop branch 5 times, most recently from f9fab20 to d0e74b8 Compare November 7, 2018 17:16
@stefanseefeld

Copy link
Copy Markdown
Owner

I have rewritten the scheduler (using Python async), so these failures should be a thing of the past.
I don't agree with this PR, though: While I understand that MSVC may actually support C++11 now, I think it's best to preserve the semantics of these specific checks. If that doesn't yield the information you want you may think of other checks that test specific C++ features, rather than only that version macro. Else we get into the muddy waters of having to decide what it actually means to support C++11, etc.

@stefanseefeld
stefanseefeld force-pushed the develop branch 7 times, most recently from 572eac6 to 05dfeed Compare July 22, 2020 14:44
@stefanseefeld
stefanseefeld force-pushed the develop branch 5 times, most recently from 8ef1164 to aa0b035 Compare August 1, 2020 21:39
@stefanseefeld
stefanseefeld force-pushed the develop branch 10 times, most recently from 739ed4c to 2d44e52 Compare December 21, 2020 19:21
@stefanseefeld
stefanseefeld force-pushed the develop branch 3 times, most recently from 148a302 to 5b9ae5e Compare December 21, 2020 20:28
@stefanseefeld
stefanseefeld force-pushed the develop branch 2 times, most recently from 1fceedf to 0f369a8 Compare February 7, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants