Skip to content

Remove unused deps.#385

Merged
leo-starkware merged 1 commit into
mainfrom
leo/remove_unused_crates
Jul 9, 2026
Merged

Remove unused deps.#385
leo-starkware merged 1 commit into
mainfrom
leo/remove_unused_crates

Conversation

@leo-starkware

@leo-starkware leo-starkware commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

This change is Reviewable

@cursor

cursor Bot commented Jul 9, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Manifest-only dependency removal with no source changes; risk is limited to a mistaken removal breaking compile, which is straightforward to catch in CI.

Overview
This PR trims direct dependencies across several workspace crates and refreshes Cargo.lock so the graph no longer pulls in crates that were only listed but unused.

cairo-program-runner drops CLI/serialization/crypto helpers (num-*, serde, starknet-*, thiserror, regex, etc.) and relies on cairo-program-runner-lib for that work. cairo-program-runner-lib removes clap. Privacy crates shed unused CLI/logging/serde stacks: privacy-circuit-verify and privacy-prove lose clap, log, sonic-rs, starknet-ff, stwo-cairo-serialize, and related entries; privacy-prove also drops circuits and thiserror. stwo-run-and-prove and stwo-run-and-prove-recursive-tree remove env_logger, starknet-ff, and stwo-cairo-serialize (recursive tree also drops log). stwo-vm-runner drops num-traits.

The lockfile cleanup removes several transitive-only packages (e.g. jiff, defmt, duplicate bitflags 1.x) that were no longer needed after the manifest edits.

Reviewed by Cursor Bugbot for commit 9e7135c. Bugbot is set up for automated code reviews on this repo. Configure here.

@Gali-StarkWare Gali-StarkWare left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Gali-StarkWare reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on leo-starkware).

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.28%. Comparing base (badc3cd) to head (9e7135c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   65.28%   65.28%           
=======================================
  Files          39       39           
  Lines        5641     5641           
=======================================
  Hits         3683     3683           
  Misses       1958     1958           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gali-StarkWare Gali-StarkWare left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on leo-starkware).

@leo-starkware leo-starkware merged commit 0a97f45 into main Jul 9, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants