chore: translation fixes

packages/.locale-state.metadata

@@ -1,4 +1,4 @@
 {
   "project": "fe-standardnotes",
-  "locale": "2286337811ccb410464f7a06c72d2fd778ec17d4"
+  "locale": "3fb9ce4bbf01734afc47838b3ac474d273daddba"
 }

packages/mobile/ios/Podfile.lock

@@ -2083,8 +2083,8 @@ SPEC CHECKSUMS:
   SNReactNative: faef9f5eaf0a5ddb64dd5a82e7aa8792d0ee050e
   SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
   TrustKit: 073855e3adecd317417bda4ac9e9ac54a2e3b9f2
-  Yoga: b94ff2d7559cb66837c97a3f394ddb817faad4d6
+  Yoga: dea3cbe52f93ef8f722493a505c1add295fe7fba
 
 PODFILE CHECKSUM: 1e9dcdd8529a4381f65c10e363e4f36675715cf2
 
-COCOAPODS: 1.16.2
+COCOAPODS: 1.15.2

packages/services/src/Domain/Contacts/UnknownContactName.ts

@@ -1,3 +1,3 @@
 import { c } from 'ttag'
 
-export const UnknownContactName = c('B6.Preferences.Vaults.Label').t`Unnamed contact`
+export const UnknownContactName = () => c('B6.Preferences.Vaults.Label').t`Unnamed contact`

packages/services/src/Domain/Contacts/UseCase/CreateOrEditContact.ts

@@ -36,7 +36,7 @@ export class CreateOrEditContact {
     }
 
     const content: TrustedContactContentSpecialized = {
-      name: params.name ?? UnknownContactName,
+      name: params.name ?? UnknownContactName(),
       publicKeySet: ContactPublicKeySet.FromJson({
         encryption: params.publicKey,
         signing: params.signingPublicKey,

packages/services/src/Domain/Strings/Messages.ts

@@ -2,12 +2,13 @@ import { ProtocolVersion } from '@standardnotes/models'
 import { c } from 'ttag'
 import { jtString, AppName, ListedName, HelpSecurityUrl, SupportEmail } from '@standardnotes/features'
 
-export const API_MESSAGE_GENERIC_INVALID_LOGIN = c('B1.Account.SignIn.Error')
-  .t`A server error occurred while trying to sign in. Please try again.`
-export const API_MESSAGE_GENERIC_REGISTRATION_FAIL = c('B1.Account.SignIn.Error')
-  .t`A server error occurred while trying to register. Please try again.`
-export const API_MESSAGE_GENERIC_CHANGE_CREDENTIALS_FAIL = c('B1.Account.SignIn.Error')
-  .t`Something went wrong while changing your credentials. Your credentials were not changed. Please try again.`
+export const API_MESSAGE_GENERIC_INVALID_LOGIN = () =>
+  c('B1.Account.SignIn.Error').t`A server error occurred while trying to sign in. Please try again.`
+export const API_MESSAGE_GENERIC_REGISTRATION_FAIL = () =>
+  c('B1.Account.SignIn.Error').t`A server error occurred while trying to register. Please try again.`
+export const API_MESSAGE_GENERIC_CHANGE_CREDENTIALS_FAIL = () =>
+  c('B1.Account.SignIn.Error')
+    .t`Something went wrong while changing your credentials. Your credentials were not changed. Please try again.`
 export const API_MESSAGE_GENERIC_SYNC_FAIL = () => c('B2.NavSharedUI.Error').t`Could not connect to server.`
 
 export const ServerErrorStrings = {
@@ -17,79 +18,85 @@ export const ServerErrorStrings = {
   },
 }
 
-export const API_MESSAGE_GENERIC_INTEGRITY_CHECK_FAIL = c('B2.NavSharedUI.Error')
-  .t`Could not check your data integrity with the server.`
+export const API_MESSAGE_GENERIC_INTEGRITY_CHECK_FAIL = () =>
+  c('B2.NavSharedUI.Error').t`Could not check your data integrity with the server.`
 
 export const API_MESSAGE_GENERIC_SINGLE_ITEM_SYNC_FAIL = () => c('B2.NavSharedUI.Error').t`Could not retrieve item.`
 
-export const API_MESSAGE_REGISTRATION_IN_PROGRESS = c('B1.Account.SignIn.Status')
-  .t`An existing registration request is already in progress.`
-export const API_MESSAGE_LOGIN_IN_PROGRESS = c('B1.Account.SignIn.Status')
-  .t`An existing sign in request is already in progress.`
-export const API_MESSAGE_CHANGE_CREDENTIALS_IN_PROGRESS = c('B1.Account.SignIn.Status')
-  .t`An existing change credentials request is already in progress.`
+export const API_MESSAGE_REGISTRATION_IN_PROGRESS = () =>
+  c('B1.Account.SignIn.Status').t`An existing registration request is already in progress.`
+export const API_MESSAGE_LOGIN_IN_PROGRESS = () =>
+  c('B1.Account.SignIn.Status').t`An existing sign in request is already in progress.`
+export const API_MESSAGE_CHANGE_CREDENTIALS_IN_PROGRESS = () =>
+  c('B1.Account.SignIn.Status').t`An existing change credentials request is already in progress.`
 
-export const API_MESSAGE_FALLBACK_LOGIN_FAIL = c('B1.Account.SignIn.Error').t`Invalid email or password.`
+export const API_MESSAGE_FALLBACK_LOGIN_FAIL = () => c('B1.Account.SignIn.Error').t`Invalid email or password.`
 
-export const API_MESSAGE_GENERIC_TOKEN_REFRESH_FAIL = c('B1.Account.Session.Error')
-  .t`A server error occurred while trying to refresh your session. Please try again.`
+export const API_MESSAGE_GENERIC_TOKEN_REFRESH_FAIL = () =>
+  c('B1.Account.Session.Error').t`A server error occurred while trying to refresh your session. Please try again.`
 
-export const API_MESSAGE_TOKEN_REFRESH_IN_PROGRESS = c('B1.Account.Session.Info')
-  .t`Your account session is being renewed with the server. Please try your request again.`
+export const API_MESSAGE_TOKEN_REFRESH_IN_PROGRESS = () =>
+  c('B1.Account.Session.Info').t`Your account session is being renewed with the server. Please try your request again.`
 
-export const API_MESSAGE_RATE_LIMITED = c('B2.NavSharedUI.Error')
-  .t`Too many successive server requests. Please wait a few minutes and try again.`
+export const API_MESSAGE_RATE_LIMITED = () =>
+  c('B2.NavSharedUI.Error').t`Too many successive server requests. Please wait a few minutes and try again.`
 
-export const API_MESSAGE_INVALID_SESSION = c('B1.Account.Session.Error')
-  .t`Please sign in to an account in order to continue with your request.`
+export const API_MESSAGE_INVALID_SESSION = () =>
+  c('B1.Account.Session.Error').t`Please sign in to an account in order to continue with your request.`
 
-export const API_MESSAGE_FAILED_GET_SETTINGS = c('B6.Preferences.Error').t`Failed to get settings.`
-export const API_MESSAGE_FAILED_UPDATE_SETTINGS = c('B6.Preferences.Error').t`Failed to update settings.`
-export const API_MESSAGE_FAILED_LISTED_REGISTRATION = jtString(
-  c('B6.Preferences.Error').jt`Unable to register for ${ListedName}. Please try again later.`,
-)
+export const API_MESSAGE_FAILED_GET_SETTINGS = () => c('B6.Preferences.Error').t`Failed to get settings.`
+export const API_MESSAGE_FAILED_UPDATE_SETTINGS = () => c('B6.Preferences.Error').t`Failed to update settings.`
+export const API_MESSAGE_FAILED_LISTED_REGISTRATION = () =>
+  jtString(c('B6.Preferences.Error').jt`Unable to register for ${ListedName}. Please try again later.`)
 
-export const API_MESSAGE_FAILED_CREATE_FILE_TOKEN = c('B7.FilesSubscriptionHelp.Files.Error')
-  .t`Failed to create file token.`
+export const API_MESSAGE_FAILED_CREATE_FILE_TOKEN = () =>
+  c('B7.FilesSubscriptionHelp.Files.Error').t`Failed to create file token.`
 
-export const API_MESSAGE_FAILED_SUBSCRIPTION_INFO = c('B7.FilesSubscriptionHelp.Subscription.Error')
-  .t`Failed to get subscription's information.`
+export const API_MESSAGE_FAILED_SUBSCRIPTION_INFO = () =>
+  c('B7.FilesSubscriptionHelp.Subscription.Error').t`Failed to get subscription's information.`
 
-export const API_MESSAGE_FAILED_ACCESS_PURCHASE = c('B7.FilesSubscriptionHelp.Subscription.Error')
-  .t`Failed to access purchase flow.`
+export const API_MESSAGE_FAILED_ACCESS_PURCHASE = () =>
+  c('B7.FilesSubscriptionHelp.Subscription.Error').t`Failed to access purchase flow.`
 
-export const API_MESSAGE_FAILED_OFFLINE_FEATURES = c('B7.FilesSubscriptionHelp.Subscription.Error')
-  .t`Failed to get offline features.`
-export const API_MESSAGE_UNTRUSTED_EXTENSIONS_WARNING = c('B2.NavSharedUI.Warning')
-  .t`The extension you are attempting to install comes from an untrusted source. Untrusted extensions may lower the security of your data. Do you want to continue?`
-export const API_MESSAGE_FAILED_DOWNLOADING_EXTENSION = c('B2.NavSharedUI.Error')
-  .t`Error downloading package details. Please check the extension link and try again.`
-export const API_MESSAGE_FAILED_OFFLINE_ACTIVATION = c('B7.FilesSubscriptionHelp.Subscription.Error')
-  .t`An unknown issue occurred during offline activation. Please download your activation code again and try once more.`
+export const API_MESSAGE_FAILED_OFFLINE_FEATURES = () =>
+  c('B7.FilesSubscriptionHelp.Subscription.Error').t`Failed to get offline features.`
+export const API_MESSAGE_UNTRUSTED_EXTENSIONS_WARNING = () =>
+  c('B2.NavSharedUI.Warning')
+    .t`The extension you are attempting to install comes from an untrusted source. Untrusted extensions may lower the security of your data. Do you want to continue?`
+export const API_MESSAGE_FAILED_DOWNLOADING_EXTENSION = () =>
+  c('B2.NavSharedUI.Error').t`Error downloading package details. Please check the extension link and try again.`
+export const API_MESSAGE_FAILED_OFFLINE_ACTIVATION = () =>
+  c('B7.FilesSubscriptionHelp.Subscription.Error')
+    .t`An unknown issue occurred during offline activation. Please download your activation code again and try once more.`
 
-export const INVALID_EXTENSION_URL = c('B2.NavSharedUI.Error').t`Invalid extension URL.`
+export const INVALID_EXTENSION_URL = () => c('B2.NavSharedUI.Error').t`Invalid extension URL.`
 
-export const UNSUPPORTED_PROTOCOL_VERSION = jtString(
-  c('B1.Account.SignIn.Error')
-    .jt`This version of the application does not support your newer account type. Please upgrade to the latest version of ${AppName} to sign in.`,
-)
+export const UNSUPPORTED_PROTOCOL_VERSION = () =>
+  jtString(
+    c('B1.Account.SignIn.Error')
+      .jt`This version of the application does not support your newer account type. Please upgrade to the latest version of ${AppName} to sign in.`,
+  )
 
-export const EXPIRED_PROTOCOL_VERSION = jtString(
-  c('B1.Account.SignIn.Error')
-    .jt`The protocol version associated with your account is outdated and no longer supported by this application. Please visit ${HelpSecurityUrl} for more information.`,
-)
+export const EXPIRED_PROTOCOL_VERSION = () =>
+  jtString(
+    c('B1.Account.SignIn.Error')
+      .jt`The protocol version associated with your account is outdated and no longer supported by this application. Please visit ${HelpSecurityUrl} for more information.`,
+  )
 
-export const UNSUPPORTED_KEY_DERIVATION = c('B1.Account.SignIn.Error')
-  .t`Your account was created on a platform with higher security capabilities than this browser supports. If we attempted to generate your login keys here, it would take hours. Please use a browser with more up to date security capabilities, like Google Chrome or Firefox, to log in.`
-
-export const INVALID_PASSWORD_COST = jtString(
+export const UNSUPPORTED_KEY_DERIVATION = () =>
   c('B1.Account.SignIn.Error')
-    .jt`Unable to sign in due to insecure password parameters. Please visit ${HelpSecurityUrl} for more information.`,
-)
-export const INVALID_PASSWORD = c('B1.Account.SignIn.Error').t`Invalid password.`
+    .t`Your account was created on a platform with higher security capabilities than this browser supports. If we attempted to generate your login keys here, it would take hours. Please use a browser with more up to date security capabilities, like Google Chrome or Firefox, to log in.`
+
+export const INVALID_PASSWORD_COST = () =>
+  jtString(
+    c('B1.Account.SignIn.Error')
+      .jt`Unable to sign in due to insecure password parameters. Please visit ${HelpSecurityUrl} for more information.`,
+  )
+export const INVALID_PASSWORD = () => c('B1.Account.SignIn.Error').t`Invalid password.`
 
-export const OUTDATED_PROTOCOL_ALERT_IGNORE = c('B1.Account.SignIn.Action').t`Sign In`
-export const UPGRADING_ENCRYPTION = c('B1.Account.Password.Status').t`Upgrading your account's encryption version…`
+export const OUTDATED_PROTOCOL_ALERT_IGNORE = () => c('B1.Account.SignIn.Action').t`Sign In`
+export const UPGRADING_ENCRYPTION = () =>
+  c('B1.Account.Password.Status').t`Upgrading your account's encryption version…`
 
 export const SETTING_PASSCODE = () => c('B5.SecuritySync.Passcode.Status').t`Setting passcode…`
 export const CHANGING_PASSCODE = () => c('B5.SecuritySync.Passcode.Status').t`Changing passcode…`
@@ -98,7 +105,7 @@ export const REMOVING_PASSCODE = () => c('B5.SecuritySync.Passcode.Status').t`Re
 export const DO_NOT_CLOSE_APPLICATION = () =>
   c('B5.SecuritySync.Passcode.Warning').t`Do not close the application until this process completes.`
 
-export const UNKNOWN_ERROR = c('B2.NavSharedUI.Error').t`Unknown error.`
+export const UNKNOWN_ERROR = () => c('B2.NavSharedUI.Error').t`Unknown error.`
 
 export function InsufficientPasswordMessage(minimum: number): string {
   return c('B1.Account.SignIn.Error')

packages/services/src/Domain/User/UserService.ts

@@ -243,7 +243,7 @@ export class UserService
     if (!success) {
       return {
         error: true,
-        message: Messages.INVALID_PASSWORD,
+        message: Messages.INVALID_PASSWORD(),
       }
     }
 
@@ -418,7 +418,7 @@ export class UserService
     }
     const dismissBlockingDialog = await this.alerts.blockingDialog(
       Messages.DO_NOT_CLOSE_APPLICATION(),
-      Messages.UPGRADING_ENCRYPTION,
+      Messages.UPGRADING_ENCRYPTION(),
     )
     try {
       let passcode: string | undefined
@@ -598,7 +598,7 @@ export class UserService
     const accountPasswordValidation = await this.encryption.validateAccountPassword(parameters.currentPassword)
     if (!accountPasswordValidation.valid) {
       return {
-        error: Error(Messages.INVALID_PASSWORD),
+        error: Error(Messages.INVALID_PASSWORD()),
       }
     }
 

packages/snjs/lib/Domain/UseCase/SignInWithRecoveryCodes/SignInWithRecoveryCodes.spec.ts

@@ -161,7 +161,7 @@ describe('SignInWithRecoveryCodes', () => {
     })
 
     expect(result.isFailed()).toBe(true)
-    expect(result.getError()).toEqual(EXPIRED_PROTOCOL_VERSION)
+    expect(result.getError()).toEqual(EXPIRED_PROTOCOL_VERSION())
   })
 
   it('should fail if the sign in with recovery code fails', async () => {

packages/snjs/lib/Domain/UseCase/SignInWithRecoveryCodes/SignInWithRecoveryCodes.ts

@@ -51,14 +51,14 @@ export class SignInWithRecoveryCodes implements UseCaseInterface<void> {
 
     if (!this.encryptionService.supportedVersions().includes(rootKeyParams.version)) {
       if (this.encryptionService.isVersionNewerThanLibraryVersion(rootKeyParams.version)) {
-        return Result.fail(UNSUPPORTED_PROTOCOL_VERSION)
+        return Result.fail(UNSUPPORTED_PROTOCOL_VERSION())
       }
 
-      return Result.fail(EXPIRED_PROTOCOL_VERSION)
+      return Result.fail(EXPIRED_PROTOCOL_VERSION())
     }
 
     if (!this.encryptionService.platformSupportsKeyDerivation(rootKeyParams)) {
-      return Result.fail(UNSUPPORTED_KEY_DERIVATION)
+      return Result.fail(UNSUPPORTED_KEY_DERIVATION())
     }
 
     const rootKey = await this.encryptionService.computeRootKey(dto.password, rootKeyParams)