Skip to content

fix(desktop): hide window when closing from fullscreen on macOS #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ketan-K17 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(desktop): hide window when closing from fullscreen on macOS #3062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/desktop/app/javascripts/Main/Window.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,22 @@ export async function createWindowState({
event.preventDefault()
/**
* Handles Mac full screen issue where pressing close results
* in a black screen.
* in a black screen. Exiting full screen is asynchronous on macOS,
* so hiding must wait until the transition finishes; otherwise the
* hide is swallowed and the window is left visible in windowed mode.
* The window is made transparent first so the user doesn't see it
* shrink back to windowed mode before disappearing.
*/
if (window.isFullScreen()) {
window.setOpacity(0)
window.once('leave-full-screen', () => {
window.hide()
window.setOpacity(1)
})
window.setFullScreen(false)
} else {
window.hide()
}
window.hide()
}
})

Expand Down