Repository navigation
test: random differential tests, and expected failures for cycles, exceptions and writing effects - #131
Open
johnsoncodehk wants to merge 6 commits into
Open
test: random differential tests, and expected failures for cycles, exceptions and writing effects#131johnsoncodehk wants to merge 6 commits into
johnsoncodehk wants to merge 6 commits into
Conversation
Co-authored-by: Johnson Chu <johnsoncodehk@users.noreply.github.com>
Co-authored-by: Johnson Chu <johnsoncodehk@users.noreply.github.com>
Co-authored-by: Johnson Chu <johnsoncodehk@users.noreply.github.com>
Co-authored-by: Johnson Chu <johnsoncodehk@users.noreply.github.com>
Co-authored-by: Johnson Chu <johnsoncodehk@users.noreply.github.com>
…n last Co-authored-by: Johnson Chu <johnsoncodehk@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests and measuring scripts only.
src/is not touched.What is added
tests/fuzz.spec.tstests/chaos.spec.tstrigger; only asserts that everything agrees with an evaluation from scratch once it has settledtests/bound.spec.tsBOUND_REPORT=1tests/errors.spec.tstests/cycle.spec.tsbenchs/instructions.mjs,benchs/wallclock.mjs,benchs/workloads.mjsExpected failures use
test.fails, so CI stays green and a fix shows up as a test that has to lose its.fails. The comment above each one states the cause. To see the actual failures:What the expected failures are
checkDirtydoes not return.flush,runorcheckDirtyhalf way. Left behind are an effect that is neither queued nor watching, effects dropped from the queue behind a computed that stays marked, a computed that stays marked while its reader is marked up to date, and a read that was never recorded as a dependency.None of these is fixed here. Every fix that was tried changes observable behaviour in some case, so they are left for a decision.
Reproducing the numbers