Contain xterm addon failures to terminal panes#7004
Open
brennanb2025 wants to merge 2 commits into
Open
Conversation
Co-authored-by: Orca <help@stably.ai>
|
Ready to review this PR? Stage has broken it down into 3 individual chapters for you:
Chapters generated by Stage for commit baced3b on Jul 1, 2026 10:23pm UTC. |
This was referenced Jul 1, 2026
Contributor
Author
|
Hard-review follow-up: two independent reviewers found WebGL fallback lifecycle gaps. Pushed baced3b to dispose a constructed WebGL addon when loadAddon throws, and to make auto mode fall back to DOM for later panes after WebGL context loss. Validation: focused Vitest terminal-search-safe-find/pane-lifecycle/terminal-link-provider-guard passed (36 tests), reliability gate manifest check passed, touched-file oxlint passed, and git diff --check passed. |
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ELI5
Terminal panes have extra pieces bolted on for things like search, links, and graphics acceleration. If one of those pieces breaks, the whole terminal should not disappear or stop accepting input. This PR proves those add-ons can fail in a contained way while the pane still stays alive enough to focus and write to.
Why We Need This
This covers the terminal-addon failure class from the recent reliability work. Terminal panes depend on optional xterm add-ons for search, link handling, and WebGL rendering. Those add-ons are useful, but they should be allowed to degrade without crashing the terminal pane, blanking the surface, or breaking focus/input.
Product Code vs Gate Coverage
This PR includes targeted product hardening plus regression coverage. The product change contains known xterm search decoration failures and WebGL attach/context-loss failures so the terminal can fall back instead of letting an add-on failure take down the pane. The tests prove that containment behavior at the renderer-unit layer; live PTY echo coverage remains a documented follow-up gap.
Merge Order
Requires #7001 first because this PR depends on the reliability gate manifest and validator added there.
After #7001 lands, this PR can merge independently of #7005, #7006, #7007, and #7008. No other child PR must merge before this one. Later child PRs may need a normal manifest rebase if this one lands first.
Why These Tests Stay Useful
experimentaluntil soak history and saved red/green evidence justify promotion.Validation
Residual Risks
Performance
Made with Orca 🐋
Post-PR Stabilization