Spark on fhir 2.0.0 - #306
Merged
Merged
Conversation
onfhir-libs 4.0.0 is on Maven Central, onfhir-definition-microservices 2.0.0 and spark-on-fhir 2.0.0 on SRDC Nexus. The first two are drop-in flips from the snapshots the migration was verified against, but spark-on-fhir 2.0.0 split the single io.onfhir:fhir-api-spark-source artifact into an io.onfhir.spark reactor: read through spark-on-fhir-connector-api, which carries spark-on-fhir-common transitively. FhirApiReader moved from io.onfhir.spark.reader to io.onfhir.spark.connector.reader, and the implicit DataFrameReader conversion behind .fhir(url) left its companion for the new SparkFhirApiConnector object. The reader's call chain and every OPTIONS constant it uses are unchanged, so nothing else in the module moves. Also drops the commented-out fhir-spark-util / fhir-path-spark entries, whose coordinates no longer exist at any version.
Every upstream dependency is a release now, leaving Ignifyr's own ${revision}
as the only -SNAPSHOT in the build, so central-portal-snapshots and
srdc-maven-snapshots resolve nothing. Removing them keeps an upstream snapshot
from drifting into a build. srdc-maven-releases stays, since the definition
microservices and spark-on-fhir are not on Central.
The environment notes still described the onFHIR dependencies as snapshots resolved from Central snapshots plus SRDC Nexus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.