Migrate MySQL parser from tidb to sqlc-dev/marino#4414
Merged
kyleconroy merged 2 commits intomainfrom Apr 27, 2026
Merged
Conversation
Marino is a sqlc-maintained hard fork of pingcap/parser with a flatter package layout. The previous test_driver concrete types (ValueExpr, ParamMarkerExpr) are merged into the ast package as ValueExprBase and ParamMarkerExprBase. - Swap github.com/pingcap/tidb/pkg/parser for github.com/sqlc-dev/marino - Drop pingcap/uber/lumberjack transitive deps no longer needed - Update dolphin imports to marino's flatter layout (no pkg/parser/...) - Replace driver.ValueExpr/ParamMarkerExpr type assertions with pcast.ValueExprBase/ParamMarkerExprBase - Replace n.TexprNode.Type with promoted n.Type (marino's exprNode is unexported, but Type is promoted via field embedding)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marino is a sqlc-maintained hard fork of pingcap/parser with a flatter
package layout. The previous test_driver concrete types (ValueExpr,
ParamMarkerExpr) are merged into the ast package as ValueExprBase and
ParamMarkerExprBase.
pcast.ValueExprBase/ParamMarkerExprBase
unexported, but Type is promoted via field embedding)