Remove pingcap/errors dependency in favor of stdlib#6
Merged
kyleconroy merged 3 commits intomainfrom Apr 26, 2026
Merged
Conversation
Replace github.com/pingcap/errors throughout the codebase with stdlib errors and fmt: - errors.Trace/WithStack drop (no stack tracing) - errors.Annotate/Annotatef use fmt.Errorf with %w via local helpers - errors.Errorf -> fmt.Errorf, errors.New -> errors.New (stdlib) - errors.Cause -> internal walker via errors.Unwrap - errors.Normalize/Error/MySQLErrorCode/RFCCodeText replaced with a local Error type in the terror package Also drop pingcap/failpoint, the only remaining dependency on pingcap/errors. Its sole usage in RedactURL was a no-op since no failpoint enable mechanism is wired up in this codebase. The redact-mode constants used by parser.Normalize move from pingcap/errors into the parser package itself.
…-errors-MGFJl # Conflicts: # go.sum # mysql/const.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace github.com/pingcap/errors throughout the codebase with stdlib
errors and fmt:
local Error type in the terror package
Also drop pingcap/failpoint, the only remaining dependency on
pingcap/errors. Its sole usage in RedactURL was a no-op since no
failpoint enable mechanism is wired up in this codebase.
The redact-mode constants used by parser.Normalize move from
pingcap/errors into the parser package itself.