Repository navigation
fix(hash-persister): quote generated scoped query words - #26
Merged
Merged
Conversation
mattnworb
marked this pull request as ready for review
October 16, 2026 20:15
honnix
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Seeded hashing falls back to full hashing when a carried target contains query punctuation. For example, the generated
set()expression inserts//:.aspect_rules_js/node_modules/@work-graph+core@0.0.0/pkgwithout quoting it, so Bazel interprets+as query syntax and rejects the query. Dirty-package and probe patterns have the same quoting gap.What changed
Quote each generated carried label, dirty-package
:allpattern, and probe:*pattern using Bazel query delimiters. Sorting, wildcard selection, and manual-target filtering are preserved.Words containing both quote delimiters cannot be represented safely. In that case, scoped hashing falls back to full computation, while a failed probe retains the unpruned dirty set.
Six related Bazel test targets pass, including regressions for the exact aspect_rules_js
/pkgand/reflabels, punctuation in packages, root packages, and quote delimiters. Actual Bazel 9.2 query evaluation also confirms target selection and probe source/manual coverage.Releasing the tool and updating the backend pin remain follow-up work. Repository-scale performance gains have not been measured.