fix media resolving for wikis on non-standard ports - #557
Open
splitbrain wants to merge 1 commit into
Open
Conversation
mpdf used the resolved local file only when its basepathIsLocal flag was set. That flag is false whenever the baseurl host differs from the request host, which a non-default port is enough to cause, since HTTP_HOST carries the port while the parsed basepath host does not. Media was then fetched over HTTP again or, for the dw2pdf:// scheme, not at all, leaving exports without images and without an error message. Fixes a regression from 3c796bb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MPDF did not use our supplied path when the wiki is running on a non-standard ports because it does some URL(host) comparison on it's own to decide if it uses $path or $originalSource. With this change it has no choice but to use what we give it.