fix docs link check for PR artifacts#289
Merged
v0lkan merged 2 commits intoJun 22, 2026
Merged
Conversation
Use a pull-request-only Lychee config that remaps internal spike.ist links to the checked-out docs artifact while preserving production-origin checks on pushes to main. Fixes: spiffe#288 Spec: specs/docs-link-check-local-artifacts.md
Fork pull_request workflows have read-only tokens, so keep uploading the Lychee report artifact but only write sticky PR comments for non-fork pull requests. Fixes: spiffe#288 Spec: specs/docs-link-check-local-artifacts.md
Contributor
|
Looking good. Merging this. -- if things still fail, we can amend updates. Thanks for your help @CoderMungan 🙏 . |
Contributor
Author
|
Thank you for reviewing and merging it. Happy to help! i will keep an eye on it and if anything fails i can help with follow-up fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a pull-request-only Lychee config that remaps internal spike.ist links to the checked-out docs artifact while preserving production-origin checks on pushes to main.
Fixes: #288
Spec: specs/docs-link-check-local-artifacts.md