Merged
Conversation
Allows to rename a wallet file from the QML Wallet Details view. This seems like a feature we should support as the use-case of a wallet can change or maybe the user didn't think about a proper name when setting up the wallet. Especially with lightning channels it is not possible to restore from seed to change the name. Fixes spesmilo#4377
SomberNight
reviewed
Apr 22, 2026
Comment on lines
+315
to
+323
| def isValidWalletName(self, wallet_name: str) -> bool: | ||
| if not wallet_name: | ||
| return False | ||
| if self.availableWallets.wallet_name_exists(wallet_name): | ||
| return False | ||
| # ensure wallet_name is not interpreted as path | ||
| if os.path.basename(wallet_name) != wallet_name: # '/foo/bar/' returns 'bar' | ||
| return False | ||
| return True |
Member
There was a problem hiding this comment.
could this be deduped with
electrum/electrum/gui/qml/qewizard.py
Line 132 in bca41d9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to rename a wallet file from the QML Wallet Details view. This seems like a feature we should support as the use-case of a wallet can change or maybe the user didn't think about a proper name when setting up the wallet. Especially with lightning channels it is not possible to restore from seed to change the name.
Fixes #4377
Alternatively it could also be made a button in the bottom row, but we already have 4 potential buttons there, i think this looks cleaner.
Screencast_20260408_103904.webm