Fix: Reopen rollback status after conflict response - #8373
Conversation
|
Warning One or more dependencies are approaching or past End-of-Life. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesRollback conflict handling
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Triggered by 6a0889a on branch refs/heads/issue-8158
emenslin
left a comment
There was a problem hiding this comment.
- Verify that the rollback dialog now opens with the "stop" button enabled and that the warning message is present
Looks good, I also verified that you can successfully rollback afterwards if you remove the linked record.
g1rly-c0d3r
left a comment
There was a problem hiding this comment.
Testing instructions
Follow steps from #8158
- Verify that the rollback dialog now opens with the "stop" button enabled and that the warning message is present
I also removed the new record then tried to roll back, and was able to.
rijulpoudel
left a comment
There was a problem hiding this comment.
- Verify that the rollback dialog now opens with the "stop" button enabled and that the warning message is present
Working as expected, the stop button shows up with the warning message.
kwhuber
left a comment
There was a problem hiding this comment.
- Verify that the rollback dialog now opens with the "stop" button enabled and that the warning message is present
There is still a successful rollback dialogue box that should not appear if rollback is prevented.
Fixes #
Checklist
self-explanatory (or properly documented)
specify7/specifyweb/specify/management/commands/run_key_migration_functions.py
Line 50 in ea04665
Testing instructions
Follow steps from #8158
Summary by CodeRabbit