Upgrade back-end code from Django 4.2 to 5.2 LTS - #8052
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughChangesDjango platform upgrade
Frontend logout flow
Sequence Diagram(s)sequenceDiagram
participant User
participant Router
participant Logout
participant AccountsLogout
participant LoginPage
User->>Router: Open command/logout
Router->>Logout: Lazy-load Logout
Logout->>AccountsLogout: POST /accounts/logout/
AccountsLogout-->>Logout: Return response
Logout->>LoginPage: Redirect with nextUrl
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning One or more dependencies are approaching or past End-of-Life. |
Triggered by ffecf67 on branch refs/heads/issue-8046
There was a problem hiding this comment.
- Ensure strings are localized correctly
- verify that labels are not raw schema labels, i.e. ensure schema config labels are respected.
- Ensure that switching languages behaves correctly.
- Log out from several locations
- Ensure that no error dialogs flash on the screen
- Logging back in takes you to the splash screen
- General UI/UX testing
- especially the workbench and attachments/attachment bulk upload
All tests pass like before and no error message on the Attachment Panel this time. I did not encounter any crashes, utcoffset errors, flashing error dialogs, or other UI regressions. Excellent job Eos!

…l` to avoid mypy `return-value` type error
… to fix `mypy` `attr-defined` type error
…` to fix `mypy` `arg-type` type error
… `attr-defined` type error
…y` can not deduce that JSONFields are iterable
rijulpoudel
left a comment
There was a problem hiding this comment.
- Ensure strings are localized correctly
- verify that labels are not raw schema labels, i.e. ensure schema config labels are respected.
- Ensure that switching languages behaves correctly.
- Log out from several locations
- Ensure that no error dialogs flash on the screen
- Logging back in takes you to the splash screen
- General UI/UX testing
- especially the workbench and attachments/attachment bulk upload
All the tests passed like the last time. All labels were oka, I was able to log out from everywhere and attachments/workbench didn't give any issues. Excellent work!
Fixes #8046
Upgrade Django from 4.2 to LTS version 5.2.
https://docs.djangoproject.com/en/6.0/releases/5.2/
Changes:
USE_L10N(A localization setting, that is now defaulted to true)GETrequest to logout to aPOSTrequest to be in HTTP (and django) speclogOutuser tool (inHeader/userToolDefinitions) to point to a new front-end endpoint:/specify/command/logoutto match the cache clearing endpointRouter/Routes.tsx) renders theLogoutcomponentLogoutcomponent makes the POST request to the backend and returns a loading screenChecklist
self-explanatory (or properly documented)
Testing instructions
Note for dev testers
If you are testing on your local instance, change
specify7/docker-compose.yml
Line 61 in 4da3228
from
--mode developmentto--mode production. This is because in development mode, webpack will duplicate web requests, which when sending thePOSTrequest, the first one is aborted by the second, which causes ajax to flash an error on-screen before refreshing to the login page. This does not happen in production mode, as far as I have seen.Summary by CodeRabbit
New Features
Bug Fixes
Refactor