Build the libspectrum commit pinned by the submodule - #69
Merged
Conversation
Makes the CI builds and the app link the same libspectrum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI built libspectrum from upstream
masterinstead of the commit pinned in3rdparty/libspectrum— the one that ships in the binary. An upstream update incompatible with this fork broke the build (example).fusex/.github/workflows/build_libspectrum_macos_sub.yml
Lines 10 to 13 in a3728dd
fusex/.github/workflows/build_libspectrum_macos_sub.yml
Lines 39 to 41 in a3728dd
Both libspectrum jobs now run
git submodule update --init 3rdparty/libspectrum, so CI builds what we ship. The hardcoded clone URL and the unusedlibspectrum_refoverride go with it.