Fix window placement on filter changes - #66
Merged
Conversation
Centring the new frame on the old one drifts the window sideways whenever the requested size is not the size AppKit grants, so one position is now shared across every filter.
A scaler large enough to widen the window past the screen edge left it hanging there, since constrainFrameRect: guarantees only that the title bar stays reachable.
Filters sharing a scaling factor, such as TV 3x and PAL TV 3x, ask for the same window size, and any manual zoom survives switching between them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the graphics filter displaced the emulator window instead of leaving it where the user put it.
Three behaviors are fixed:
The window now keeps one position across every filter, stays within the visible screen area, and is left untouched when the filter does not change its size.