Skip to content

certify/check-rmap-updates-by-default - #1242

Merged
alphasentaurii merged 4 commits into
spacetelescope:mainfrom
alphasentaurii:check-rmap-updates
Oct 7, 2026
Merged

alphasentaurii merged 4 commits into
spacetelescope:mainfrom
alphasentaurii:check-rmap-updates

Conversation

@alphasentaurii

@alphasentaurii alphasentaurii commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Resolves CCD-1799, CRDS-1108

Certify now checks rmap updates by default (trial insertion of reference files into appropriate rmaps). Previously the user was required to pass in the "-u"/"--check-rmap-updates" flag into the certify script in order to check reference file insertion errors (such as equal weight special case errors). This is now True by default, with a deprecation warning added to the help message pointing users to the new "-z"/"--dont-check-rmap-updates" flag if they explicitly want to turn this behavior off.

Note - Condition added where trial rmap update step is skipped if any per-file certify errors are detected.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
news fragment change types...
  • changes/<PR#>.hst.rst: HST reference files
  • changes/<PR#>.jwst.rst: JWST reference files
  • changes/<PR#>.roman.rst: Roman reference files
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.testing.rst: change to tests or test automation
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@alphasentaurii
alphasentaurii requested a review from a team as a code owner October 5, 2026 18:37
@alphasentaurii
alphasentaurii merged commit 53f15af into spacetelescope:main Oct 7, 2026
10 checks passed
@alphasentaurii
alphasentaurii deleted the check-rmap-updates branch October 7, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant