Skip to content

Allow HEAD on the search endpoint#1022

Merged
jviotti merged 1 commit into
mainfrom
search-head
Jun 6, 2026
Merged

Allow HEAD on the search endpoint#1022
jviotti merged 1 commit into
mainfrom
search-head

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented Jun 6, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Jun 6, 2026

🤖 Augment PR Summary

Summary: This PR adds support for HEAD requests on the schema search REST endpoint.

Changes:

  • Updates the search action to accept both GET and HEAD, and to advertise this via the Allow header on 405 responses.
  • Extends the end-to-end Hurl test suites (headless + html) to validate RFC 9110 behavior: HEAD returns the same headers as GET while returning an empty body.

Technical Notes: Tests cover successful searches (with and without matches) and an error path (missing query) to ensure header parity and zero response bytes for HEAD.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: 992d654 Previous: 077bec8 Ratio
Add one schema (0 existing) 383 ms 402 ms 0.95
Add one schema (100 existing) 67 ms 30 ms 2.23
Add one schema (1000 existing) 92 ms 94 ms 0.98
Add one schema (10000 existing) 791 ms 750 ms 1.05
Update one schema (1 existing) 59 ms 22 ms 2.68
Update one schema (101 existing) 28 ms 30 ms 0.93
Update one schema (1001 existing) 90 ms 96 ms 0.94
Update one schema (10001 existing) 808 ms 760 ms 1.06
Cached rebuild (1 existing) 5 ms 7 ms 0.71
Cached rebuild (101 existing) 8 ms 9 ms 0.89
Cached rebuild (1001 existing) 26 ms 32 ms 0.81
Cached rebuild (10001 existing) 220 ms 289 ms 0.76
Index 100 schemas 644 ms 647 ms 1.00
Index 1000 schemas 1398 ms 1481 ms 0.94
Index 10000 schemas 13578 ms 13684 ms 0.99
Index 10000 schemas (custom meta-schema) 109055 ms 138126 ms 0.79

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: 992d654 Previous: 077bec8 Ratio
Add one schema (0 existing) 321 ms 298 ms 1.08
Add one schema (100 existing) 24 ms 27 ms 0.89
Add one schema (1000 existing) 68 ms 87 ms 0.78
Add one schema (10000 existing) 559 ms 813 ms 0.69
Update one schema (1 existing) 18 ms 20 ms 0.90
Update one schema (101 existing) 23 ms 26 ms 0.88
Update one schema (1001 existing) 69 ms 89 ms 0.78
Update one schema (10001 existing) 558 ms 803 ms 0.69
Cached rebuild (1 existing) 5 ms 6 ms 0.83
Cached rebuild (101 existing) 6 ms 8 ms 0.75
Cached rebuild (1001 existing) 19 ms 26 ms 0.73
Cached rebuild (10001 existing) 157 ms 223 ms 0.70
Index 100 schemas 578 ms 646 ms 0.89
Index 1000 schemas 1272 ms 1325 ms 0.96
Index 10000 schemas 10819 ms 16867 ms 0.64
Index 10000 schemas (custom meta-schema) 131887 ms 108495 ms 1.22

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit c0b1748 into main Jun 6, 2026
5 checks passed
@jviotti jviotti deleted the search-head branch June 6, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant