Repository navigation
[orchagent] Remove DTEL orch - #4975
Open
spandan-nexthop wants to merge 1 commit into
Open
spandan-nexthop wants to merge 1 commit into
spandan-nexthop wants to merge 1 commit into
Conversation
We are deprecating DTEL (data-plane telemetry) because Barefoot Tofino, the only hardware platform that supported it, is end-of-life. Remove DTelOrch, its AclOrch integration (the DTEL_FLOW_WATCHLIST ACL table and watchlist rules), the SAI DTEL API handle in saihelper, and test_dtel.py. Update AclOrch constructor callers in the unit tests. The SAI DTEL API itself is unchanged. Signed-off-by: Spandan Chowdhury <spandan@nexthop.ai>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This was referenced Oct 5, 2026
Collaborator
|
Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks! ---Powered by SONiC BuildBot
|
spandan-nexthop
marked this pull request as ready for review
October 6, 2026 20:55
Author
nh-grecs Bot
pushed a commit
to nexthop-ai/sonic-swss
that referenced
this pull request
Oct 7, 2026
rebuild-source: sonic-net/pull/4975 @ nexthop-ai/sonic-swss 7fc50f6 [case: upstream:open]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Deprecating DTEL (data-plane telemetry), since Barefoot Tofino, the only hardware platform that supported it, is end-of-life. This change is made per item 7.1.3 of the SONiC 202611 EOL and deprecation plan.
Remove DTelOrch and all DTEL handling from orchagent. The SAI DTEL API itself is unchanged; orchagent simply stops calling it.
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
With Barefoot Tofino end-of-life, DTelOrch has no supported hardware and is dead code in orchagent.
How did you do it?
orchagent/dtelorch.cppandorchagent/dtelorch.h, and drop them fromorchagent/Makefile.amandtests/mock_tests/Makefile.am.orchdaemon.cpp: remove the DTEL table set and the DTelOrch initialization.aclorch.{h,cpp}: remove the DTEL ACL actions,AclRuleDTelWatchListEntry, the internalDTEL_FLOW_WATCHLISTACL table, the INT session observer handling, and theDTelOrch *parameters ofAclOrch::AclOrch()andAclRule::makeShared().TABLE_TYPE_DTEL_FLOW_WATCHLIST(acltable.h),SUBJECT_TYPE_INT_SESSION_CHANGE(observer.h) and thesai_dtel_apihandle (saihelper.cpp).tests/test_dtel.py; update theAclOrchconstructor callers inp4orch/testsandmock_tests.Behavior changes:
vsplatform (the only non-Barefoot platform that enabled DTelOrch), AclOrch no longer creates the internalDTEL_FLOW_WATCHLISTACL table at startup.STATE_DB SWITCH_CAPABILITY|switchno longer publishesACL_ACTION|FLOW_OPor the DTEL ACL actions inACL_ACTIONS|INGRESS/ACL_ACTIONS|EGRESS.ACL_RULEorACL_TABLE_TYPEthat uses a DTEL action is rejected as an unknown action.How did you verify/test it?
p4orch/testsandmock_testssource with-fsyntax-onlyand the repository's warning flags, before and after the change: no new errors or warnings.crates/countersyncd, which tracks the SAI API.default_acl_tables), so they are not affected by the removed internal table.Any platform specific information?
DTelOrch was only instantiated on the
barefootandvsplatforms.Documentation
The DTEL design documents are removed in the SONiC repository PR listed below. The
sonic-swss-commonPR below must merge after this one.Related PRs