Repository navigation
redis: preserve the source endpoint in AsyncDBUpdater - #1259
Merged
qiluo-msft merged 1 commit intoOct 9, 2026
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
ashutosh-agrawal
marked this pull request as ready for review
October 7, 2026 18:43
qiluo-msft
requested review from
StormLiangMS
and removed request for
StormLiangMS
October 7, 2026 23:20
Signed-off-by: Ashutosh Agrawal <ashu@cisco.com>
ashutosh-agrawal
force-pushed
the
redis-local-uds-endpoint
branch
from
October 8, 2026 04:29
f54657b to
8d749ac
Compare
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I changed
AsyncDBUpdaterto create its worker connection withm_db->newConnector(0).Why
AsyncDBUpdaterperforms background database writes, including writes used by ZMQ state-table persistence.The caller can connect to Redis through a Unix socket. However,
AsyncDBUpdaterpreviously rebuilt its worker connection with the TCP option forced on. This created the following failure:AsyncDBUpdatercreates a separate TCP connection for queued writes.Creating the worker with
newConnector()preserves the endpoint already selected by the caller and removes that mismatch.How the test covers the fix
AsyncDBUpdaterand waits for the worker to process it.