Repository navigation
Add PR template and align copilot-instructions - #572
Closed
oleksandrivantsiv wants to merge 1 commit into
Closed
oleksandrivantsiv wants to merge 1 commit into
oleksandrivantsiv wants to merge 1 commit into
Conversation
Add a pull_request_template.md with the standard SONiC PR sections (What I did / Why I did it / How I verified it / Details if related) and align the PR description guidance in copilot-instructions.md to reference the same sections. Signed-off-by: Oleksandr Ivantsiv <oivantsiv@nvidia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
May 13, 2026
saiarcot895
reviewed
May 13, 2026
1 of 5 tasks
Collaborator
|
@saiarcot895 @oleksandrivantsiv are we good with the PR? can we merge it? |
Collaborator
kindly reminder |
Contributor
|
My comment above is still pending. |
Collaborator
Author
|
@liat-grozovik Closing in favor of #579: the same template as the other SONiC repos, plus the upstreaming question @saiarcot895 asked for here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
.github/pull_request_template.mdcontaining the standard SONiC PR sections (What I did/Why I did it/How I verified it/Details if related).PR descriptionguidance in.github/copilot-instructions.mdto reference the same four sections defined by the new template.Why I did it
The repository did not have a PR template in
.github/, so contributors were not prompted with the SONiC PR description structure when opening a pull request. Alignedcopilot-instructions.mdso its PR guidance matches the new template.How I verified it
Visual inspection of the updated files.
Details if related