SDK update - #106
SDK update#106
Conversation
…DK updates New features: - Added services for API Tokens, ISO Images, VPC Networks, Languages, Storage Tags, and Usage. - Updated Client to register new services. Core updates: - Updated request handling to support 200 OK on DELETE. - Added StopWithRequest to VirtualServersService. Maintenance: - Cosmetic documentation updates in generated files.
09d446d to
5936408
Compare
5936408 to
64c7847
Compare
pvokhmyanin
left a comment
There was a problem hiding this comment.
looks good to me! thanks!
64c7847 to
413a402
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the Go SDK to add new API surface (API Tokens, ISO Images, VPC Networks, Languages, Storage Tags, Usage) and applies core request-handling updates (notably allowing DELETE to succeed on 200 OK) plus a new StopWithRequest variant for virtual servers.
Changes:
- Added new services/resources and their filters/responses (API tokens, ISO images, languages, VPC networks, usage, storage tags).
- Updated the client to register the new services.
- Updated request handling: allow
200 OKon syncDELETE, and add a genericpost()helper + “empty body” handling for POST/CREATE.
Reviewed changes
Copilot reviewed 30 out of 46 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| vpcNetworks_test.go | Adds unit tests for VPC network attach/detach. |
| vpcNetworks_gen_test.go | Adds autogenerated pagination cursor tests for VPC networks and VPC network IPs. |
| vpcNetworks_gen.go | Adds autogenerated Next() pagination helpers for VPC network responses. |
| vpcNetworksFilter.go | Adds VPC network list filter type. |
| vpcNetworks.go | Adds VPC networks service + models + CRUD and IP/attach operations. |
| virtual_servers_gen_test.go | Renames pagination test to match VirtualServersResponse. |
| virtual_servers_gen.go | Cosmetic formatting updates in generated docs/comments. |
| virtual_servers.go | Adds StopRequest + StopWithRequest to virtual servers service. |
| users_gen.go | Cosmetic formatting updates in generated docs/comments. |
| usage_test.go | Adds unit test for usage retrieval with filters. |
| usageFilter.go | Adds usage filter type. |
| usage.go | Adds usage service + response/model types. |
| tasks_gen.go | Cosmetic formatting updates in generated docs/comments. |
| storageTags.go | Adds storage tags service with Delete. |
| sshKeys_gen.go | Cosmetic formatting updates in generated docs/comments. |
| roles_gen.go | Cosmetic formatting updates in generated docs/comments. |
| request_test.go | Adds tests for empty POST/CREATE bodies and new post() helper. |
| request.go | Adds post() helper, supports empty response bodies, and allows DELETE 200 OK. |
| projects_gen.go | Cosmetic formatting updates in generated docs/comments. |
| projectServers_gen.go | Cosmetic formatting updates in generated docs/comments. |
| plans_gen.go | Cosmetic formatting updates in generated docs/comments. |
| permissions_gen.go | Cosmetic formatting updates in generated docs/comments. |
| osImages_gen.go | Cosmetic formatting updates in generated docs/comments. |
| locations_gen.go | Cosmetic formatting updates in generated docs/comments. |
| languages_gen_test.go | Adds autogenerated pagination cursor tests for languages. |
| languages_gen.go | Adds autogenerated Next() pagination helper for languages. |
| languagesFilter.go | Adds languages list filter type. |
| languages.go | Adds languages service + models. |
| isoImages_gen_test.go | Adds autogenerated pagination cursor tests for ISO images. |
| isoImages_gen.go | Adds autogenerated Next() pagination helper for ISO images. |
| isoImagesFilter.go | Adds ISO images list filter type. |
| isoImages.go | Adds ISO images service + models. |
| ipBlocks_gen.go | Cosmetic formatting updates in generated docs/comments. |
| icons_gen.go | Cosmetic formatting updates in generated docs/comments. |
| computeResource_gen.go | Cosmetic formatting updates in generated docs/comments. |
| client.go | Registers the newly added services on Client. |
| backups_test.go | Expands delete tests to cover 204 and 200 OK responses; updates IsFinished coverage. |
| backups.go | Adds BackupStatusCreating. |
| applications_gen.go | Cosmetic formatting updates in generated docs/comments. |
| applications.go | Adds ApplicationsService.Update. |
| apiTokens_gen_test.go | Adds autogenerated pagination cursor tests for API tokens. |
| apiTokens_gen.go | Adds autogenerated Next() pagination helper for API tokens. |
| apiTokensFilter.go | Adds API tokens list filter type. |
| apiTokens.go | Adds API tokens service + models + CRUD methods. |
| additionalDisks.go | Changes Disk.ActualSize from int to float64. |
| activityLogs_gen.go | Cosmetic formatting updates in generated docs/comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
413a402 to
5eabba4
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 46 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 46 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 36 out of 52 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @amisa, thanks for the review! The nil if resp == nil || len(body) == 0 {
return nil
}
return unmarshal(body, resp)Also fixed the |
feat: add support for API Tokens, ISO Images, VPC Networks and core SDK updates
New features:
Core updates:
Maintenance: