Skip to content

SDK update - #106

Merged
amisa merged 3 commits into
solusio:masterfrom
Artem151193:tech_sdk_update
Jul 7, 2026
Merged

amisa merged 3 commits into
solusio:masterfrom
Artem151193:tech_sdk_update

Conversation

@Artem151193

Copy link
Copy Markdown
Contributor

feat: add support for API Tokens, ISO Images, VPC Networks and core SDK updates

New features:

  • Added services for API Tokens, ISO Images, VPC Networks, Languages, Storage Tags, and Usage.
  • Updated Client to register new services.

Core updates:

  • Updated request handling to support 200 OK on DELETE.
  • Added StopWithRequest to VirtualServersService.

Maintenance:

  • Cosmetic documentation updates in generated files.

…DK updates

New features:
- Added services for API Tokens, ISO Images, VPC Networks, Languages, Storage Tags, and Usage.
- Updated Client to register new services.

Core updates:
- Updated request handling to support 200 OK on DELETE.
- Added StopWithRequest to VirtualServersService.

Maintenance:
- Cosmetic documentation updates in generated files.
Comment thread virtual_servers_gen_test.go Outdated
Comment thread apiTokens_gen_test.go Outdated
Comment thread isoImages_gen_test.go Outdated
Comment thread vpcNetworks_gen_test.go Outdated
Comment thread request.go
Comment thread vpcNetworks.go Outdated
Comment thread vpcNetworks.go
Comment thread usage.go
Comment thread usage.go Outdated
Comment thread usage.go
Comment thread apiTokens.go Outdated

@pvokhmyanin pvokhmyanin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! thanks!

Comment thread vpcNetworks.go
Copilot AI review requested due to automatic review settings February 19, 2026 16:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Go SDK to add new API surface (API Tokens, ISO Images, VPC Networks, Languages, Storage Tags, Usage) and applies core request-handling updates (notably allowing DELETE to succeed on 200 OK) plus a new StopWithRequest variant for virtual servers.

Changes:

  • Added new services/resources and their filters/responses (API tokens, ISO images, languages, VPC networks, usage, storage tags).
  • Updated the client to register the new services.
  • Updated request handling: allow 200 OK on sync DELETE, and add a generic post() helper + “empty body” handling for POST/CREATE.

Reviewed changes

Copilot reviewed 30 out of 46 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
vpcNetworks_test.go Adds unit tests for VPC network attach/detach.
vpcNetworks_gen_test.go Adds autogenerated pagination cursor tests for VPC networks and VPC network IPs.
vpcNetworks_gen.go Adds autogenerated Next() pagination helpers for VPC network responses.
vpcNetworksFilter.go Adds VPC network list filter type.
vpcNetworks.go Adds VPC networks service + models + CRUD and IP/attach operations.
virtual_servers_gen_test.go Renames pagination test to match VirtualServersResponse.
virtual_servers_gen.go Cosmetic formatting updates in generated docs/comments.
virtual_servers.go Adds StopRequest + StopWithRequest to virtual servers service.
users_gen.go Cosmetic formatting updates in generated docs/comments.
usage_test.go Adds unit test for usage retrieval with filters.
usageFilter.go Adds usage filter type.
usage.go Adds usage service + response/model types.
tasks_gen.go Cosmetic formatting updates in generated docs/comments.
storageTags.go Adds storage tags service with Delete.
sshKeys_gen.go Cosmetic formatting updates in generated docs/comments.
roles_gen.go Cosmetic formatting updates in generated docs/comments.
request_test.go Adds tests for empty POST/CREATE bodies and new post() helper.
request.go Adds post() helper, supports empty response bodies, and allows DELETE 200 OK.
projects_gen.go Cosmetic formatting updates in generated docs/comments.
projectServers_gen.go Cosmetic formatting updates in generated docs/comments.
plans_gen.go Cosmetic formatting updates in generated docs/comments.
permissions_gen.go Cosmetic formatting updates in generated docs/comments.
osImages_gen.go Cosmetic formatting updates in generated docs/comments.
locations_gen.go Cosmetic formatting updates in generated docs/comments.
languages_gen_test.go Adds autogenerated pagination cursor tests for languages.
languages_gen.go Adds autogenerated Next() pagination helper for languages.
languagesFilter.go Adds languages list filter type.
languages.go Adds languages service + models.
isoImages_gen_test.go Adds autogenerated pagination cursor tests for ISO images.
isoImages_gen.go Adds autogenerated Next() pagination helper for ISO images.
isoImagesFilter.go Adds ISO images list filter type.
isoImages.go Adds ISO images service + models.
ipBlocks_gen.go Cosmetic formatting updates in generated docs/comments.
icons_gen.go Cosmetic formatting updates in generated docs/comments.
computeResource_gen.go Cosmetic formatting updates in generated docs/comments.
client.go Registers the newly added services on Client.
backups_test.go Expands delete tests to cover 204 and 200 OK responses; updates IsFinished coverage.
backups.go Adds BackupStatusCreating.
applications_gen.go Cosmetic formatting updates in generated docs/comments.
applications.go Adds ApplicationsService.Update.
apiTokens_gen_test.go Adds autogenerated pagination cursor tests for API tokens.
apiTokens_gen.go Adds autogenerated Next() pagination helper for API tokens.
apiTokensFilter.go Adds API tokens list filter type.
apiTokens.go Adds API tokens service + models + CRUD methods.
additionalDisks.go Changes Disk.ActualSize from int to float64.
activityLogs_gen.go Cosmetic formatting updates in generated docs/comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread vpcNetworks.go
Comment thread virtual_servers.go Outdated
Comment thread apiTokens.go
Comment thread storageTags.go
Comment thread vpcNetworks.go
Comment thread request.go
Comment thread request.go
Comment thread isoImages.go
Comment thread languages.go

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 46 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread virtual_servers.go
Comment thread applications.go

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 46 changed files in this pull request and generated 9 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread vpcNetworksFilter.go Outdated
Comment thread usageFilter.go Outdated
Comment thread apiTokens.go
Comment thread vpcNetworks.go
Comment thread languagesFilter.go Outdated
Comment thread isoImagesFilter.go Outdated
Comment thread apiTokensFilter.go Outdated
Comment thread languages.go
Comment thread isoImages.go

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 36 out of 52 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Artem151193

Copy link
Copy Markdown
Contributor Author

Hi @amisa, thanks for the review!

The nil resp panic you pointed out in vpcNetworks.go (AddIPs, Attach, Detach) has been addressed in commit 5eabba4. The create and post helpers in request.go now guard against nil / empty body before calling unmarshal:

if resp == nil || len(body) == 0 {
    return nil
}
return unmarshal(body, resp)

Also fixed the &resp -> resp issue (resp is already an interface{}). Could you please re-review when you have a moment? Thanks!

@amisa
amisa merged commit 9b5942d into solusio:master Jul 7, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants