Skip to content

Make use of dirEntType in sourceDirectoryDeep - #527

Open
sjshuck wants to merge 3 commits into
snoyberg:masterfrom
sjshuck:d_type
Open

sjshuck wants to merge 3 commits into
snoyberg:masterfrom
sjshuck:d_type

Conversation

@sjshuck

@sjshuck sjshuck commented Jul 6, 2025

Copy link
Copy Markdown

This is halfway towards #459. The other half is getting dirEntType itself fixed in unix, which is currently hard-coded to return UnknownType and effectively reverts to the current behavior of stat()ing every file. That fix is haskell/unix#348. They can be merged in any order.

Benchmarks running sourceDirectoryDeep into sinkNull from my home dir (about 500K files):

Follow symlinks? Time
Current ✗ 1.71s
Current ✓ 3.19s
After this PR ✗ 1.70s
After this PR ✓ 3.18s
After this and the unix PR ✗ 0.94s
After this and the unix PR ✓ 1.96s

@sjshuck

sjshuck commented Sep 16, 2025

Copy link
Copy Markdown
Author

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant