Fixed deserialising string/blob payloads when transferred with chunked-encoding#1292
Merged
Merged
Conversation
Contributor
Author
|
Alternatively, how about something like c9c7901 instead? |
mtdowling
approved these changes
Jul 13, 2026
mtdowling
enabled auto-merge (rebase)
July 13, 2026 17:44
Member
|
Thanks! Good catch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1291
What behavior changes?
Describe the observable difference in behavior before and after this change.
Fixed handling string/blob http payloads with chunked encoding.
Why is this change needed?
Explain the motivation: bug, feature request, refactor, performance, etc.
Negative (-1) content length is a valid value which indicates that the value just isn't known ahead of time. If a server responds with chunked encoding, the value will not be known ahead of time and it will result in the response being ignored (only when http payloads on string/blob was being used).
How was this validated?
List tests added, benchmarks run, or manual verification performed.
Run tests, built and test locally.
What should reviewers focus on?
Point reviewers to the files or sections that contain the interesting logic.
I guess it might be possible that whilst the content length is not known ahead of time but it resolves to empty response in the end it might cause some issues?
Additional Links
Related issues, design docs, or prior art.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.