Repository navigation
fix(cli): require check-holdings to run as the --admin party - #1232
Draft
JohnChangUK wants to merge 1 commit into
Draft
JohnChangUK wants to merge 1 commit into
JohnChangUK wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
check-holdingsnow fails before reading the ledger when the configured party is not the--adminparty. Only the registrar is a stakeholder of every registry holding, so a run as any other party sees only part of them and could pass clean.checkHoldings.go: compareb.Participant.PartyIDwith--adminafter resolving the participant and return an error on mismatch.Not counted: golangci-lint run also fails before the change; go build ./... passed in CI, a dependency does not build here. Checked: make upgrade-check, make compile-contracts, make generate-bindings, make gomodtidy, make gomodtidy, make go-generate, make mocks, make inspect-dars