Refactor CLI to make it testable using testscript#1426
Merged
Conversation
github-actions
Bot
added
the
needs triage
hslatman
force-pushed
the
herman/testscript
branch
from
May 22, 2025 10:33
4fc2791 to
b69ee0e
Compare
This was referenced May 27, 2025
hslatman
force-pushed
the
herman/testscript
branch
3 times, most recently
from
May 30, 2025 17:27
ae24576 to
4832304
Compare
In CI the TTY is not available, and will result in this error: `error reading password: error allocating terminal: open /dev/tty: no such device or address` We prevent this by using the `--password-file` flag.
hslatman
force-pushed
the
herman/testscript
branch
from
June 12, 2025 13:24
4832304 to
6de4059
Compare
hslatman
force-pushed
the
herman/testscript
branch
from
June 12, 2025 13:31
6de4059 to
298ff27
Compare
hslatman
force-pushed
the
herman/testscript
branch
from
June 12, 2025 23:00
f229d6a to
1a494ce
Compare
hslatman
marked this pull request as ready for review
June 13, 2025 10:40
hslatman
force-pushed
the
herman/testscript
branch
from
June 13, 2025 13:28
eb550ee to
92a5eab
Compare
hslatman
force-pushed
the
herman/testscript
branch
from
June 13, 2025 13:33
92a5eab to
2944159
Compare
maraino
requested changes
Jun 16, 2025
maraino
left a comment
maraino
left a comment
Collaborator
There was a problem hiding this comment.
A few comments, and a rename of a couple of files.
maraino
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the CLI and its integration tests to use the testscript package.
As part of that, this PR:
testscriptDSLintegrationbuild tagCoverage before:
Coverage after:
Coverage data was created by running the tests with go-acc, and the visualization was created using go-cover-treemap. Coverage clearly increased in the parts of the code base that had existing integration tests and were refactored, but weren't included in code coverage before.