tocify: clean up event handlers and helper divs.#210
tocify: clean up event handlers and helper divs.#210MathieuDuponchelle wants to merge 35 commits into
Conversation
Add git to allow rake build
Use strict mode for JavaScript
Update normalize.css to version 3.0.2
Update Rouge to Version 1.8
Update JavaScript libraries
Update Middleman to version 3.3.9
Rename SCSS files, so no unnecessary stylesheets are generated.
Saves 26,9% on logo png and a whopping 96,6% on navbar.png
Optimize images
Update and cleanup dependencies
Adding IBM Cloudant to the example list
Update README.md
Prevents bugs with special CSS characters. Closes #201.
Don't use a selector to get the heading text for search results.
+ This allows to call the plugin again when the content of the page has changed.
|
I don't have any plans on pushing the tocify changes upstream, but if somebody else wanted to take that on, they'd be more than welcome! Thanks for the PR, I'll take a look when I get the chance. |
|
@MathieuDuponchelle sorry this has taken so long to get to! It looks like there are a number of merge conflicts — in the next version of Slate, we'll be replacing Tocify anyways, so would you be alright with me just closing this PR? If you'd like to rebase and clean it up I'd be glad to merge it then, but I just don't want to make you do all that work for something that will get removed in the next version anyways! |
|
Yup, no problem, FWIW I've started a different project at https://github.com/hotdoc/hotdoc , here's a quick demo : https://www.youtube.com/watch?v=jQd1zJIJQRE |
Fix the extension info for package repository plugin info.
6 participants
page has changed.
I've proposed a similar change to tocify itself @ gfranko/jquery.tocify.js#77 , are there plans to upstream slate-specific changes (height and anchor caching) ?