Skip to content

Support Android 7 (API level 24)#108

Open
dfabulich wants to merge 2 commits into
skiptools:mainfrom
dfabulich:android-7
Open

Support Android 7 (API level 24)#108
dfabulich wants to merge 2 commits into
skiptools:mainfrom
dfabulich:android-7

Conversation

@dfabulich

Copy link
Copy Markdown
Member

There are various bugs still on Android 7, but 99% of the app works.

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

@marcprux

marcprux commented Jun 2, 2026

Copy link
Copy Markdown
Member

99% of the app works

What is the 1% like? Crashes, glitches, or other bugs?

- block: 'create("libs")'
remove: ['version("android-sdk-min", "28")']
contents:
- 'version("android-sdk-min", "24")'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than doing this, can you just manually set minSdk = 24 in the build.gradle.kts? I think the only place we reference libs.versions.android.sdk.min from the android-sdk-min version in the versionCatalogs is in the app's build.gradle.kts, so I don't think there is any point in overriding it at the version catalog level (for that matter, I wonder why we even bother setting it at all in the versionCatalogs, but we're stuck with it now since all the pre-existing app build.gradle.kts files are referencing it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants