Conversation
M-arcus
marked this pull request as draft
September 8, 2026 10:34
M-arcus
marked this pull request as ready for review
September 8, 2026 11:42
M-arcus
force-pushed
the
modern-image-serving-via-accept-header
branch
from
September 8, 2026 11:47
f3b5b1c to
1674da6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how the tool checks for modern image formats (like AVIF and WebP) to more accurately detect what image formats are actually served to users. The main logic for detecting modern image formats has been moved from the DOM-based script to a new HAR-based rule, which inspects the actual Content-Type headers in HTTP responses. This approach avoids false positives/negatives caused by relying on file extensions or DOM heuristics, and allows for correct handling of Accept-based content negotiation. The update also introduces comprehensive tests for the new logic and adds support for new image MIME types in the test webserver.
Modern image format detection overhaul:
lib/dom/performance/modernImageFormats.jswith a new HAR-based rule inlib/har/performance/modernImageFormats.jsthat checks the actual Content-Type delivered, ensuring accurate identification of legacy and modern image formats regardless of URL or markup. [1] [2]Utility enhancements:
util.getResourceContentTypefunction inlib/dom/util.jsto allow in-page scripts to retrieve the real Content-Type of resources using the PerformanceResourceTiming API, although this is now less central due to the HAR-based approach.Test improvements:
test/har/performance/modernImageFormatsTest.js, covering various scenarios including content negotiation, content-type casing/parameters, partial legacy/modern mixes, missing content-types, and exclusion of tracking pixels.test/help/webserver.jsto serve.webpand.aviffiles with correct MIME types, and makes a minor refactor to directory handling logic. [1] [2]Test cleanup: