cas lenient attributes parsing

[ioigoume]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.78%. Comparing base (b5f30a3) to head (643c166).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
+ Coverage     95.75%   96.78%   +1.03%     
- Complexity       54       57       +3     
============================================
  Files            10       10              
  Lines           212      218       +6     
============================================
+ Hits            203      211       +8     
+ Misses            9        7       -2     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tvdijen]

What is this 'slate' thing and why does it break the CAS-specifications on so many levels?
Really, I think they should make their own specification...

What we could do is create xml-cas-module-slate repository with versions of the XML-classes that need to be altered in order to interoperate with slate.
Then in simplesamlphp-module-casserver we add a feature-flag to enable/disable slate-support. If enabled then a class-alias has to be set so that the customized version of the class is used instead of the default.

There is an example for this here to support SPID, which is an accent of SAML2. I must admit I have never tested it though. I think it would come down to customized versions of AuthenticationSuccess and Attributes.

[ioigoume]

What is this 'slate' thing and why does it break the CAS-specifications on so many levels? Really, I think they should make their own specification...

What we could do is create xml-cas-module-slate repository with versions of the XML-classes that need to be altered in order to interoperate with slate. Then in simplesamlphp-module-casserver we add a feature-flag to enable/disable slate-support. If enabled then a class-alias has to be set so that the customized version of the class is used instead of the default.

There is an example for this here to support SPID, which is an accent of SAML2. I must admit I have never tested it though. I think it would come down to customized versions of AuthenticationSuccess and Attributes.

Thank you for the feedback @tvdijen . I've sent you a PM.

[tvdijen]

As a reminder we should revert c5e73d8 when the module is finished.