Skip to content

LT-22425: Fix testSetTextEmpty for Release builds#847

Merged
papeh merged 9 commits intomainfrom
fix/separate-tests-for-CD
Apr 22, 2026
Merged

LT-22425: Fix testSetTextEmpty for Release builds#847
papeh merged 9 commits intomainfrom
fix/separate-tests-for-CD

Conversation

@papeh
Copy link
Copy Markdown
Contributor

@papeh papeh commented Apr 21, 2026

Summary

Sleep 1ms at the beginning of the MockTextStoreACPSink ctor to prevent an "unknown exception" in the test for VwTextStore.SetTextEmpty in Release builds (Debug builds are fine).

Also

  • Add a -SkipManagedTests switch to build.ps1
  • Split tests into a separate execution step for installer builds for consistency with CI builds and more manageable log sizes

Notes for reviewers (optional)

Another option is to cout << "";, which also spends enough time doing effectively nothing to cause the test to pass, and doesn't require two extra #includes, but sleeping rather than couting when the goal is to kill time feels more principled to me.


This change is Reviewable

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   7m 11s ⏱️ + 1m 5s
4 103 tests ±0  4 032 ✅ ±0  71 💤 ±0  0 ❌ ±0 
4 112 runs  ±0  4 041 ✅ ±0  71 💤 ±0  0 ❌ ±0 

Results for commit b204d9b. ± Comparison against base commit 59c00b0.

♻️ This comment has been updated with latest results.

@papeh
Copy link
Copy Markdown
Contributor Author

papeh commented Apr 21, 2026

This works, and the logs look nice in the GHA web interface, but the downloaded build.log is missing the native logs. https://github.com/sillsdev/FieldWorks/actions/runs/24748859269 tests a tweak that I hope will fix this.

@github-actions
Copy link
Copy Markdown

⚠️ Commit Message Format Issues ⚠️
commit b204d9b50b:
3: B5 Body message is too short (16<20): "not just stdout."

Copy link
Copy Markdown
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on papeh).

@papeh papeh merged commit dc6e876 into main Apr 22, 2026
6 of 7 checks passed
@papeh papeh deleted the fix/separate-tests-for-CD branch April 22, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants