LT-22425: Fix testSetTextEmpty for Release builds#847
Merged
Conversation
Contributor
Author
|
This works, and the logs look nice in the GHA web interface, but the downloaded build.log is missing the native logs. https://github.com/sillsdev/FieldWorks/actions/runs/24748859269 tests a tweak that I hope will fix this. |
not just stdout.
|
|
mark-sil
approved these changes
Apr 22, 2026
Contributor
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on papeh).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sleep 1ms at the beginning of the MockTextStoreACPSink ctor to prevent an "unknown exception" in the test for VwTextStore.SetTextEmpty in Release builds (Debug builds are fine).
Also
Notes for reviewers (optional)
Another option is to
cout << "";, which also spends enough time doing effectively nothing to cause the test to pass, and doesn't require two extra#includes, but sleeping rather than couting when the goal is to kill time feels more principled to me.This change is