Repository navigation
Conversation
Upgrade openid-client to 6.8.8 and adapt discovery, PKCE, and code exchange to the v6 API. Preserve Basic client authentication and ID-token signature verification, normalize callback redirect URIs, and expand OAuth regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Brian DeHamer <bdehamer@github.com>
🦋 Changeset detectedLatest commit: ae376c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
openid-clientfrom 5.7.0 to 6.8.8 and migrate the CLI's browser authentication to the v6 API. Supersedes the dependency-only update in #1767, which fails to compile against the removed v5 APIs.Preserve PKCE, state and nonce validation, Basic authentication for clients with a secret, and ID-token signature verification (which requires an explicit opt-in in v6). Resolve relative callback URLs against the configured redirect URL and normalize that URL so authorization and token exchange use the same redirect URI, including the default bare localhost origin.
Update the OAuth tests to mock Fetch responses, add regression coverage for invalid tokens and callback parameters, and configure Jest to transform the new ESM dependencies. Include a CLI patch changeset and document v6's HTTPS issuer requirement; local HTTP callbacks remain supported. No Node engine or module-format changes are needed.
Validation
https://oauth2.sigstore.dev/authsucceed on Node 22.22.2.A parallel full-suite rerun hit Nock interception errors in eight OCI proxy tests. Those tests pass in isolation, and the complete suite passes serially. Interactive browser login has not been exercised manually.