rust(feat): mcp rate-limiting#641
Merged
Merged
Conversation
evan-sift
reviewed
Jun 18, 2026
solidiquis
requested changes
Jun 19, 2026
solidiquis
approved these changes
Jun 19, 2026
evan-sift
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements gRPC status handling for backoff and retries in the mcp.
We construct each Service with a
Retry Policythat outlines how to handle gRPC status codes. In here we implement a retry loop that takes in a closure. With this new structure we wrap our gRPC calls within the retry loop so we can handle the gRPC status codes when they come in.When the retry layer gives up, we give the agent a soft-signal to not retry this tool without the user providing more context or the general shape of the request is different. We do handle the different tonic statuses differently.
Following the status codes laid out here: https://google.aip.dev/194
UNAVAILABLE= Retry with backoff, then soft signal on exhaustionRESOURCE_EXHAUSTED, DEADLINE_EXCEEDED, INTERNAL, ABORTED, ALREADY_EXISTS, PERMISSION_DENIED, UNAUTHENTICATED, CANCELLED= Immediate error return with soft signalErrors without set soft-guidance are given a hard rmcp error code back:
INVALID_ARGUMENT and OUT_OF_RANGE=INVALID_PARAMSNOT_FOUND=RESOURCE_NOT_FOUNDUNIMPLEMENTED=METHOD_NOT_FOUNDFAILED_PRECONDITION, DATA_LOSS, UNKNOWN=INTERNAL_ERRORWhat this does not limit:
Verification