Repository navigation
feat: supplier timeliness metric plus testing, funding and CLI guides - #723
Merged
Merged
Conversation
|
@king-aj-the-first Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses four issues in one branch with four separate commits.
#631 feat: supplier on-time milestone rate metric
SupplierTimeliness { on_time, late }contract type andDataKeyExt4::SupplierTimeliness(Address)storage key with TTL extension on every write.confirm_milestoneheld and direct paths,batch_confirm_milestones,confirm_milestone_graded,claim_auto_confirmation): on-time whenproof_submitted_ledger <= deadline_ledger, late otherwise. Milestones without a deadline are ignored.get_supplier_timeliness(supplier)getter; the confirming party is authenticated by the underlying confirmation call, which also appends themilestone_confirmedshipment audit entry.timeliness_recordedevent.test_supplier_timelinessmodule (happy path, late, exact-deadline edge, no-deadline ignored, event emission, authorization failure, invalid index) anddocs/supplier-timeliness.md.storage.rs(pre-existing, blocked all compilation); remaining build errors in the repo are pre-existing merge drift unrelated to this change.#688 docs: testing guide
docs/testing.mdcovering module layout andlib.rsregistration,test_common.rsfixtures, snapshot tests withUPDATE_SNAPSHOTS=1, proptest usage, and theenv.events().all()last-invocation pitfall. Linked from the README.#690 docs: buyer funding options
docs/funding.mdcovering direct funding plustop_up_escrow, the escrow vault (vault_deposit/vault_withdraw/get_vault_balancewithfund_from_vault), standing orders (create_standing_order/execute_standing_order/cancel_standing_order/get_standing_order), allowance-based funding (create_shipment_with_allowance), and interaction with buyer spending limits and the TVL cap. Linked from the README.#687 docs: Stellar CLI cookbook
docs/cli.mdwith copy-pastestellar contract invokeexamples forinit,create_shipment(struct/vector encoding),submit_proof,confirm_milestone,raise_dispute/resolve_dispute, and admin config (add_allowed_token,set_fee_config,set_tvl_cap). Linked from the README.Closes #631
Closes #688
Closes #690
Closes #687