Repository navigation
AI Assistant - integrated frontend - #1
Open
voidmatcha wants to merge 14 commits into
Open
voidmatcha wants to merge 14 commits into
voidmatcha wants to merge 14 commits into
Conversation
seung-00
force-pushed
the
feature/notebook-assistant
branch
2 times, most recently
from
September 27, 2026 08:12
2b94979 to
5b712df
Compare
voidmatcha
force-pushed
the
voidmatcha/ai-assistant-panel
branch
from
September 27, 2026 08:40
53266fe to
e175a6f
Compare
voidmatcha
force-pushed
the
voidmatcha/ai-assistant-panel
branch
6 times, most recently
from
October 5, 2026 07:09
14ace35 to
87f44aa
Compare
seung-00
force-pushed
the
feature/notebook-assistant
branch
9 times, most recently
from
October 6, 2026 11:19
b4b7b4f to
d9b205b
Compare
voidmatcha
force-pushed
the
voidmatcha/ai-assistant-panel
branch
from
October 9, 2026 01:55
87f44aa to
5dcf1a5
Compare
voidmatcha
force-pushed
the
voidmatcha/ai-assistant-panel
branch
3 times, most recently
from
October 9, 2026 02:23
61867f6 to
df44660
Compare
seung-00
force-pushed
the
feature/notebook-assistant
branch
from
October 10, 2026 00:40
749832f to
f56fd5d
Compare
voidmatcha
force-pushed
the
voidmatcha/ai-assistant-panel
branch
from
October 10, 2026 00:50
df44660 to
f9d25ea
Compare
seung-00
force-pushed
the
feature/notebook-assistant
branch
from
October 10, 2026 08:22
f56fd5d to
d698333
Compare
voidmatcha
force-pushed
the
voidmatcha/ai-assistant-panel
branch
from
October 10, 2026 08:27
108603d to
74aae59
Compare
seung-00
force-pushed
the
feature/notebook-assistant
branch
from
October 10, 2026 08:28
d698333 to
bab263f
Compare
voidmatcha
force-pushed
the
voidmatcha/ai-assistant-panel
branch
from
October 10, 2026 08:37
74aae59 to
a5c35e6
Compare
seung-00
force-pushed
the
feature/notebook-assistant
branch
from
October 10, 2026 12:16
bab263f to
398cb79
Compare
voidmatcha
force-pushed
the
voidmatcha/ai-assistant-panel
branch
from
October 10, 2026 13:40
a5c35e6 to
104e260
Compare
seung-00
force-pushed
the
feature/notebook-assistant
branch
from
October 10, 2026 15:10
398cb79 to
5c2c52d
Compare
Keep editor model lifecycle and diff handling isolated from the Assistant panel changes. Confidence: high Scope-risk: none Not-tested: Historical intermediate state not separately built.
Update the shared React host and dependency baseline before adding Assistant contracts. Confidence: high Scope-risk: none Not-tested: Historical intermediate state not separately built.
Expose the host slots and the conversation data contract shared by Angular and React. Confidence: high Scope-risk: none Not-tested: Historical intermediate state not separately built.
Build Assistant stories and publish previews for pushed branches. Confidence: high Scope-risk: none Not-tested: Historical intermediate state not separately built.
Add the React transport for Assistant conversation REST and notebook WebSocket events. Server-side recovery changes remain in the separate server branch. Confidence: high Scope-risk: Recovery needs the server follow-up changes to be merged. Not-tested: Live browser E2E against the original server branch.
Add Assistant messages, Markdown rendering, controls, styles, and component stories. Confidence: high Scope-risk: none Not-tested: Historical intermediate state not separately built.
Compose run state, conversation history, drafts, and the notebook panel. Confidence: high Scope-risk: none Not-tested: Historical intermediate state not separately built.
Wire the Angular notebook host to the React panel and paragraph reveal behavior. Confidence: high Scope-risk: none Not-tested: Historical intermediate state not separately built.
Cover the mounted panel with a fake Assistant backend and exercise auth-sensitive flows in the notebook browser tests. Confidence: high Scope-risk: none Not-tested: Live browser E2E after the commit split.
Use message history to settle disconnected runs because the server does not expose a running field. Drop status polling and its tests; keep the transport aligned with the reviewed implementation. Confidence: high Scope-risk: Recovery now depends on successful history reload after disconnect. Not-tested: Live server reconnect and saturated server queue.
voidmatcha
force-pushed
the
voidmatcha/ai-assistant-panel
branch
from
October 10, 2026 15:46
104e260 to
351bc90
Compare
Use the shared Assistant slot type and keep the mounted socket stable as host slots change. Cover the sidebar shell and align its E2E page annotation. Confidence: high Scope-risk: The integrated PR still depends on the server PR base. Not-tested: Live browser E2E against the server.
Drop the retired publishing workflow and update the React development dependency lock and license inventory to match the standalone Storybook PR. Confidence: high Scope-risk: Preview publishing is intentionally absent from this branch. Not-tested: A clean dependency install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shows the integrated AI Assistant frontend on top of
seung-00:feature/notebook-assistant. It contains no Java orzeppelin-serverchanges. The frontend commits cover the code editor fix, shared host prerequisites, contracts, local Storybook, transport, UI, notebook integration, and E2E coverage.Upstream review is split across #5558, #5561, #5562, #5563, and #5565 sidebar shell, with the remaining UI changes to follow. The integrated panel carries apache#5565's sidebar width, close-button, and mount-lifecycle fixes without replacing the conversation UI. Storybook is configured for local use; the branch-specific publishing workflow has been removed.
On the current head, the SDK build, SDK contract and React typechecks, 37 focused Angular shell tests, and Storybook build pass. React unit tests, lint, and isolated Chromium geometry checks passed before the latest synchronization commits and have not been rerun on this head. The live notebook E2E has not been rerun against the current server branch.