Fix ArithmeticException: divide by zero in MainActivity#211
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Fix ArithmeticException: divide by zero in MainActivity#211cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Fixes ANDROID-EA - Wrapped the division by zero operation in a try-catch block - Captured the exception using Sentry.captureException() instead of letting it crash - Changed comment from 'Unhandled' to 'Handled' to reflect the fix - Follows the same pattern as other handled exceptions in the code
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 864 867 +3
Branches 65 65
=====================================
- Misses 864 867 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The app was crashing with an
ArithmeticException: divide by zerowhen users clicked the division by zero button in MainActivity.Solution
Fixed the unhandled ArithmeticException by:
Sentry.captureException()for proper error trackingChanges
MainActivity.javato handle the ArithmeticException instead of letting it crash the appTesting
The fix follows the established pattern in the codebase (see lines 64-76 for ArrayIndexOutOfBoundsException handling).
Fixes ANDROID-EA