feat: add sem-approve command parameters to include secrets, enable cache in forked PRs#1026
Open
dexyk wants to merge 19 commits into
Open
feat: add sem-approve command parameters to include secrets, enable cache in forked PRs#1026dexyk wants to merge 19 commits into
dexyk wants to merge 19 commits into
Conversation
dexyk
force-pushed
the
dk/sem_full_approve
branch
3 times, most recently
from
July 13, 2026 12:28
8d79691 to
2c84018
Compare
dexyk
marked this pull request as ready for review
July 13, 2026 12:28
dexyk
force-pushed
the
dk/sem_full_approve
branch
from
July 14, 2026 09:07
2c84018 to
da922f0
Compare
…ache in forked PRs
…ption for clarity
…ecurity measures and documentation
- Introduced `RepoHost::Github::ApprovalCommand` with tests for command recognition and option parsing. - Updated `RepoHost::Github::Payload` tests to utilize a helper method for creating comment payloads, improving readability and maintainability. - Enhanced `WebhookFilter` tests to ensure proper handling of approval commands, including edge cases for inline commands, blockquotes, and trailing text. - Modified `Handler` tests to bind approval actions to the correct workflow based on comment timestamps, ensuring that approvals are not affected by subsequent pushes. - Updated permission checks to use immutable user IDs instead of usernames, enhancing security and reliability.
…erve settings on feature disable
…d update tests for feature behavior
dexyk
force-pushed
the
dk/sem_full_approve
branch
from
July 22, 2026 11:31
da922f0 to
8d0bbc8
Compare
… provide context on versioning
…ents and improve readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds
/sem-approve --include-secretsand--enable-cachefor forked pull requests, letting a project member grant an approved forked-PR workflow the project secrets and build cache that forks are denied by default. zebra applies this to pipeline jobs only, debug/attach filtering, org secret-access rules (JOB_DEBUG_NO/JOB_ATTACH_NO), and the SSH-debug gate are unchanged. The whole capability is gated by a new org feature flagsem_approve_options(off by default).✅ Checklist