Make cache use zstd compression#555
Open
skipi wants to merge 4 commits into
Open
Conversation
The cache command will now create zstd-compressed archives. When decompressing, it attempts to compress as Zstd first, but if the magic bytes do not match, it falls back to gzip compression.
# Conflicts: # cache-cli/pkg/archive/shell_out_archiver.go
CI revive flagged the zstd work that never ran on the original fork PR: - rename is_zstd -> isZstd (var-naming) in shell_out_archiver.go and native_archiver.go - drop else-after-return in newCompressingWriter (indent-error-flow) Co-authored-by: Bert Peters <bert@bertptrs.nl>
|
I see there are still some CI failures that I didn't catch locally, mainly with the minimal images not including Zstd by default. Is this an issue for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of #530 by @bertptrs, pushed as an in-repo branch so CI can run — fork PRs cannot access the project secrets the pipeline needs, so the workflow never triggers on the original.
All commits are authored by @bertptrs; credit is theirs. Closes #530 once this is green and merged.
Co-authored-by: Bert Peters bert@bertptrs.nl