docs: correct the Windows compiler claim in README#4
Merged
Conversation
The build requirements listed "MSVC >= VS 2019", but CI never builds with the MSVC cl compiler. The Windows lane uses clang-cl (clang with the MSVC ABI) under the MSVC toolchain, because the project's glib dependency is exercised there via clang-cl, not cl. GCC is covered on Linux and Clang on macOS. State the compilers that are actually supported and tested, and drop the unverified VS 2019 floor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The build-requirements list claims
MSVC >= VS 2019, but that is notwhat the project builds or tests. CI never invokes the MSVC
clcompiler — the Windows lane (see
ci-pr.yml/ci-main.yml) configureswith clang-cl (clang targeting the MSVC ABI) under the MSVC
toolchain, because the glib dependency is exercised through clang-cl,
not
cl. The>= VS 2019floor is likewise unverified (CI runs onwindows-latest = VS 2022).
Fix
State the compilers that are actually supported and tested — GCC
(Linux), Clang (macOS), and clang-cl with the MSVC toolchain (Windows) —
and drop the unverified VS 2019 floor.
Docs-only change.