ci: put vcpkg bin on PATH so Windows tests find the glib DLL#3
Merged
Conversation
libwiig links glib-2.0 and the test binaries (test_skeleton via wiig_dep, test_lexer directly) pull it in too. The vcpkg x64-windows triplet ships glib as a DLL, so the test executables need glib-2.0-0.dll and its dependencies on PATH at run time; without it the test step dies with a missing-DLL load failure before any assertion runs. Prepend %VCPKG_INSTALLED_DIR%\bin to PATH in the configure and build/test steps of both Windows jobs, matching the proven clang-cl + vcpkg setup used by the sibling glib-on-Windows project. The compiler stays clang-cl: pure MSVC cl cannot build the glib headers, so the MSVC-ABI-via-clang path is the supported one here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
libwiiglinks glib-2.0, and the test binaries pull it in too(
test_skeletonviawiig_dep,test_lexerdirectly). The vcpkgx64-windowstriplet ships glib as a DLL, so the test executablesneed
glib-2.0-0.dlland its dependencies onPATHat run time.Without that, the Windows test step dies with a missing-DLL load failure
before any assertion runs.
Fix
Prepend
%VCPKG_INSTALLED_DIR%\bintoPATHin the configure andbuild/test steps of both Windows jobs (
ci-pr.yml,ci-main.yml),matching the proven clang-cl + vcpkg setup used by the sibling
glib-on-Windows project (wyrelog).
The compiler stays clang-cl: pure MSVC
clcannot build the glibheaders, so the MSVC-ABI-via-clang path is the supported one here.
Verification
Windows-only CI change; validated by the build-windows job on this PR.