Skip to content
This repository was archived by the owner on Jun 10, 2020. It is now read-only.

Move enzyme-adapter-react-16 to devDeps#276

Open
Kerumen wants to merge 1 commit into
seatgeek:masterfrom
Kerumen:master
Open

Move enzyme-adapter-react-16 to devDeps#276
Kerumen wants to merge 1 commit into
seatgeek:masterfrom
Kerumen:master

Conversation

@Kerumen

@Kerumen Kerumen commented Apr 9, 2018

Copy link
Copy Markdown

enzyme-adapter-react-16 is only required for the tests, it shouldn't be included in the dependencies.

@coveralls

coveralls commented Apr 9, 2018

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 90.741% when pulling 15f1edf on Kerumen:master into d4517c9 on seatgeek:master.

@danalloway

Copy link
Copy Markdown

LGTM

@kgregory kgregory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct

@chrisvoll

Copy link
Copy Markdown
Member

@Kerumen thanks for the PR! Do you know why there were so many changes in package-lock.json? It should only contain { "dev": true } changes

@Kerumen

Kerumen commented Jul 24, 2018

Copy link
Copy Markdown
Author

@chrisvoll I don't know, I just moved the package and ran npm i.

Maybe npm changed his way to manage lock files since it has been generated. I have npm v6.2.0.

@geminiyellow

Copy link
Copy Markdown

hi @kgregory , why don't you merge this PR?
please merge it and publish a new version.

@kgregory

Copy link
Copy Markdown
Contributor

@geminiyellow I am not a maintainer

@geminiyellow

Copy link
Copy Markdown

opps, sorry @kgregory , you review and approve the PR, so think you are maintainer.
and this library last merge is half year ago. is it still alive ? @garetht

@kgregory

Copy link
Copy Markdown
Contributor

@geminiyellow I used this library in the past and was hopeful that it would be updated for React 16, but it doesn’t look good. I reviewed some issues and PRs to help out, but it doesn’t appear to have much support. Prove me wrong @garetht!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants