This repository was archived by the owner on Jun 10, 2020. It is now read-only.
Creating a 'onChangeScrollState' callback function prop…#227
Open
alexkb0009 wants to merge 5 commits into
Open
Creating a 'onChangeScrollState' callback function prop…#227alexkb0009 wants to merge 5 commits into
alexkb0009 wants to merge 5 commits into
Conversation
…(if exists) in componentDidUpdate when pastState.isScrolling !== this.state.isScrolling. Also, allowing function props/handlers to be null or undefined to prevent function call/binding when not needed.
…s to be a more accurate timing as perhaps no need to wait for React to perform update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to be called (if exists) in componentDidUpdate when pastState.isScrolling !== this.state.isScrolling. Maybe it should go into componentWillUpdate?
This function prop allows me to set "pointer-events: none" on a parent element while scrolling. In my case, list items (
displayables) are within a horizontally scrollable container which causes Chrome to lag/skip slightly during scrolling. Settingpointer-events: noneon the element withoverflow-x: auto, during vertical scrolling, fixes this.Another edit included in this PR is changing a couple of defaultProps for function props/properties from
function(){}to either null or undefined, so function doesn't get bound to an element at all if not provided/used. Point was to slightly improve performance, if possible.In near future, would like to convert to ES6 module syntax (
class Infinite extends React.Component { ...) if no one else has started on this.