Conversation
glemson
requested changes
Sep 2, 2026
| boolean canEditComputeDomain(User u, ComputeDomain cd) { | ||
| return racm.doesUserHaveRoleOnResource(u.getUsername(), cd.getResourceContext().getUuid(), RACMNames.CONTEXT_ROOTRESOURCE_PUBDID, RACMNames.R_COMPUTE_DOMAIN_ROOT_ADMIN); | ||
| } | ||
| boolean canRegisterDatabaseContext(User u, ComputeDomain cd) { |
Contributor
There was a problem hiding this comment.
would it be better to add this method on RDBDomainManager?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Authorization: addDbContextToRDBComputeDomain now checks the registerDatabaseContext right on the domain's root context (new JOBMAccessControl.canRegisterDatabaseContext) instead of testing for the admin role by name.
Authentication: the endpoint now requires the X-Service-Auth-ID header and rejects it unless it resolves to the domain in the path, same as submitJob. RACMClient.registerRDBComputeDbContext gained a serviceToken param as well.
Callers now need both the domain's service token and the register right, when only a plain user token used to be enough in the past.